Source/core/rendering/RenderBox.h - Issue 385583005: For flex items, percent paddings should resolve against their respective dimension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 385583005: For flex items, percent paddings should resolve against their respective dimension Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/css3/flexbox/percent-padding-expected.txt ('k') | Source/core/rendering/RenderBoxModelObject.h » ('j') | Source/core/rendering/RenderBoxModelObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index e6702ffb2bd7f6e8c39c0bc56e1666ecd74e411f..fc947b4e3f1531e04908cf6b84f754728bd72743 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -623,6 +623,7 @@ public:

}

virtual void invalidateTreeAfterLayout(const PaintInvalidationState&) OVERRIDE;

+ bool skipContainingBlockForPercentHeightCalculation(const RenderBox* containingBlock) const;

protected:

virtual void willBeDestroyed() OVERRIDE;

@@ -680,8 +681,6 @@ private:

// Returns true if we did a full repaint

bool repaintLayerRectsForImage(WrappedImagePtr, const FillLayer&, bool drawingBackground);

- bool skipContainingBlockForPercentHeightCalculation(const RenderBox* containingBlock) const;

LayoutUnit containingBlockLogicalWidthForPositioned(const RenderBoxModelObject* containingBlock, bool checkForPerpendicularWritingMode = true) const;

LayoutUnit containingBlockLogicalHeightForPositioned(const RenderBoxModelObject* containingBlock, bool checkForPerpendicularWritingMode = true) const;