LayoutTests/css3/flexbox/percent-margins-padding.html - Issue 385583005: For flex items, percent paddings should resolve against their respective dimension

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/flexbox/percent-margins-padding.html

Issue 385583005: For flex items, percent paddings should resolve against their respective dimension Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP Patch 3 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <link href="resources/flexbox.css" rel="stylesheet">

	4 <style>

	5 .flexbox {

	6 background: green;

	7 position: relative;

	8 }

	9 </style>

	10 <script src="../../resources/check-layout.js"></script>

	11 <body onload="checkLayout('.flexbox')">

	12 <div class="flexbox" style="height:100px; padding: 10px; border:2px solid red;">
	leviw_travelin_and_unemployed 2014/07/15 20:08:29 Nit: please promote the repeated inline styles to Nit: please promote the repeated inline styles to the above sheet. harpreet.sk 2014/07/16 15:43:01 Done. Show quoted text On 2014/07/15 20:08:29, leviw wrote: > Nit: please promote the repeated inline styles to the above sheet. Done.
	13 <div id="flexItem1" data-expected-padding-top="10" data-expected-padding-bot tom="10" style="background:yellow; padding:10%;">Pasta batman</div>

	14 </div>

	15

	16 <div class="flexbox" style="height:30%; padding: 10px; border:2px solid red;">

	17 <div id="flexItem2" data-expected-padding-top="0" data-expected-padding-bott om="0" style="padding:20%; background:yellow">Pasta batman</div>

	18 </div>

	19

	20 <div class="flexbox" style="padding: 10px; border:2px solid red;">

	21 <div id="flexItem3" data-expected-padding-top="0" data-expected-padding-bott om="0" style="padding:30%; background:yellow">Pasta batman</div>

	22 </div>

	23

	24 <div style="height:200px; padding: 10px; border:2px solid red;">

	25 <div class="flexbox" style="height:30%">

	26 <div id="flexItem2" data-expected-padding-top="12" data-expected-padding -bottom="12" style="padding:20%; background:yellow">Pasta batman</div>

	27 </div>

	28 </div>

	29

	30 <div style="height:200px; padding: 10px; border:2px solid red;">

	31 <div style="height:40%">

	32 <div class="flexbox" style="height:30%">

	33 <div id="flexItem2" data-expected-padding-top="12" data-expected-padding -bottom="12" style="padding:50%; background:yellow">Pasta batman</div>

	34 </div>

	35 </div>

	36 </div>

	37

	38 <div class="flexbox" style="height:min-content; padding: 10px; border:2px solid red;">

	39 <div id="flexItem1" data-expected-padding-top="0" data-expected-padding-bott om="0" style="background:yellow; padding:10%;">Pasta batman</div>

	40 </div>

	41

	42 <div class="flexbox" style="height:max-content; padding: 10px; border:2px solid red;">

	43 <div id="flexItem1" data-expected-padding-top="0" data-expected-padding-bott om="0" style="background:yellow; padding:10%;">Pasta batman</div>

	44 </div>

	45

	46 <div class="flexbox" style="height:fit-content; padding: 10px; border:2px solid red;">

	47 <div id="flexItem1" data-expected-padding-top="0" data-expected-padding-bott om="0" style="background:yellow; padding:10%;">Pasta batman</div>

	48 </div>

	49

	50 <div class="flexbox" style="min-height:100px; max-height:100px; padding: 10px; b order:2px solid red;">

	51 <div id="flexItem1" data-expected-padding-top="0" data-expected-padding-bott om="0" style="background:yellow; padding:10%;">Pasta batman</div>

	52 </div>

	53 </body>

	54 </html>

OLD	NEW