Issue 385553002: BackoffEntry is used to compute timeouts between consecutive captive portal checks.

Issue 385553002: BackoffEntry is used to compute timeouts between consecutive captive portal checks. (Closed)

Created:
6 years, 5 months ago by ygorshenin1

Modified:
6 years, 5 months ago

Reviewers:
Denis Kuznetsov (DE-MUC), Nikita (slow), antrim

CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

BackoffEntry is used to compute timeouts between consecutive captive portal checks. BUG=377725 TEST=unit_tests:NetworkPortalDetectorImplTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284726

Patch Set 1 #

Patch Set 2 : Fixes. #

Patch Set 3 : Fixes. #

Patch Set 4 : . #

Patch Set 5 : . #

Total comments: 4

Patch Set 6 : Fixes. #

Patch Set 7 : Removed uint64, added comment to the BackoffEntry::Policy initialization. #

Patch Set 8 : Removed static_cast. #

Patch Set 9 : Rebase. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+270 lines, -250 lines)			Patch
M	chrome/browser/chromeos/net/network_portal_detector_impl.h	View	1 2 3 4 5 6 7 8	5 chunks	+22 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_impl.cc	View	1 2 3 4 5 6 7 8	12 chunks	+55 lines, -51 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc	View	1 2 3 4 5 6 7 8	35 chunks	+139 lines, -89 lines	0 comments	Download
M	chromeos/network/portal_detector/network_portal_detector_strategy.h	View	1 2 3 4 5 6	4 chunks	+17 lines, -18 lines	0 comments	Download
M	chromeos/network/portal_detector/network_portal_detector_strategy.cc	View	1 2 3 4 5 6 7 8	9 chunks	+37 lines, -79 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

antrim

https://codereview.chromium.org/385553002/diff/80001/chrome/browser/chromeos/net/network_portal_detector_impl.h File chrome/browser/chromeos/net/network_portal_detector_impl.h (right): https://codereview.chromium.org/385553002/diff/80001/chrome/browser/chromeos/net/network_portal_detector_impl.h#newcode172 chrome/browser/chromeos/net/network_portal_detector_impl.h:172: uint64 no_response_result_count_for_testing() const { What is the reason for ...

6 years, 5 months ago (2014-07-10 13:53:14 UTC) #2

ygorshenin1

PTAL https://codereview.chromium.org/385553002/diff/80001/chrome/browser/chromeos/net/network_portal_detector_impl.h File chrome/browser/chromeos/net/network_portal_detector_impl.h (right): https://codereview.chromium.org/385553002/diff/80001/chrome/browser/chromeos/net/network_portal_detector_impl.h#newcode172 chrome/browser/chromeos/net/network_portal_detector_impl.h:172: uint64 no_response_result_count_for_testing() const { Due to errors or ...

6 years, 5 months ago (2014-07-11 11:46:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/385553002/160001

6 years, 5 months ago (2014-07-22 13:37:59 UTC) #7

Nikita (slow)

From another CL: https://codereview.chromium.org/383183002/diff/1/chromeos/network/portal_dete... chromeos/network/portal_detector/network_portal_detector_strategy.cc:105: virtual base::TimeDelta GetNextAttemptTimeoutImpl() OVERRIDE { Sounds reasonable. I'll change https://codereview.chromium.org/385553002/ ...

6 years, 5 months ago (2014-07-23 08:42:41 UTC) #9

Nikita (slow)

6 years, 5 months ago (2014-07-23 08:42:51 UTC) #10

Message was sent while issue was closed.

From another CL:

https://codereview.chromium.org/383183002/diff/1/chromeos/network/portal_dete...
chromeos/network/portal_detector/network_portal_detector_strategy.cc:105:
virtual base::TimeDelta GetNextAttemptTimeoutImpl() OVERRIDE {
Sounds reasonable. I'll change https://codereview.chromium.org/385553002/
accordingly.

On 2014/07/14 09:16:49, Nikita Kostylev wrote:
> (suggestion for future CL)
> 
> How about always start with "slow attempt" when current status is online (i.e.
> there's low chance of this status being changed quickly) and with fast attempt
> when not online?

What's the timeout between captive portal checks when connection status is
online now?

Expand Messages | Collapse Messages