Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: cc/base/ref_counted_managed.h

Issue 38553002: cc: Add tile pool to tile manager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/ref_counted.cc ('k') | cc/resources/picture_layer_tiling_perftest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/base/ref_counted_managed.h
diff --git a/cc/base/ref_counted_managed.h b/cc/base/ref_counted_managed.h
index 8bb836f015957ceecac9ee7d0e04193bb0ee3e91..02ad6ee95fea99f2fffe1b96e734839b37344cc4 100644
--- a/cc/base/ref_counted_managed.h
+++ b/cc/base/ref_counted_managed.h
@@ -32,11 +32,16 @@ template <typename T>
class CC_EXPORT RefCountedManaged : public base::subtle::RefCountedBase {
public:
explicit RefCountedManaged(RefCountedManager<T>* manager)
- : manager_(manager) {
- manager_->live_object_count_++;
+ : manager_(manager),
+ released_(true) {
}
void AddRef() const {
+ if (released_) {
+ released_ = false;
+ ClearInDtor();
+ manager_->live_object_count_++;
+ }
base::subtle::RefCountedBase::AddRef();
}
@@ -45,6 +50,8 @@ class CC_EXPORT RefCountedManaged : public base::subtle::RefCountedBase {
DCHECK_GT(manager_->live_object_count_, 0);
manager_->live_object_count_--;
+ released_ = true;
+
// This must be the last statement in case manager deletes
// the object immediately.
manager_->Release(static_cast<T*>(this));
@@ -56,6 +63,7 @@ class CC_EXPORT RefCountedManaged : public base::subtle::RefCountedBase {
private:
RefCountedManager<T>* manager_;
+ mutable bool released_;
DISALLOW_COPY_AND_ASSIGN(RefCountedManaged<T>);
};
« no previous file with comments | « base/memory/ref_counted.cc ('k') | cc/resources/picture_layer_tiling_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698