Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 385523002: [XHR] Remove a browsertest to update forbidden headers. (Closed)

Created:
6 years, 5 months ago by yhirano
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[XHR] Remove a browsertest to update forbidden headers. In order to update forbidden header names in Blink side, I remove a subtest from a browsertest. I will restore the subtest once the Blink side CL[1] is landed. 1: https://codereview.chromium.org/378183003/ BUG=373120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282507

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 2 chunks +5 lines, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
yhirano
6 years, 5 months ago (2014-07-10 01:27:22 UTC) #1
dmichael (off chromium)
lgtm
6 years, 5 months ago (2014-07-10 16:10:02 UTC) #2
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 5 months ago (2014-07-10 23:45:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/385523002/1
6 years, 5 months ago (2014-07-10 23:45:47 UTC) #4
commit-bot: I haz the power
Change committed as 282507
6 years, 5 months ago (2014-07-11 02:37:44 UTC) #5
pfeldman
https://codereview.chromium.org/385523002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc File chrome/test/ppapi/ppapi_browsertest.cc (right): https://codereview.chromium.org/385523002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc#newcode452 chrome/test/ppapi/ppapi_browsertest.cc:452: // LIST_TEST(URLLoader_UntrustedHttpRequests) \ gcc fails compiling this.
6 years, 5 months ago (2014-07-11 09:54:40 UTC) #6
yhirano
6 years, 5 months ago (2014-07-11 09:56:33 UTC) #7
Message was sent while issue was closed.
On 2014/07/11 09:54:40, pfeldman wrote:
>
https://codereview.chromium.org/385523002/diff/1/chrome/test/ppapi/ppapi_brow...
> File chrome/test/ppapi/ppapi_browsertest.cc (right):
> 
>
https://codereview.chromium.org/385523002/diff/1/chrome/test/ppapi/ppapi_brow...
> chrome/test/ppapi/ppapi_browsertest.cc:452: //     
> LIST_TEST(URLLoader_UntrustedHttpRequests)      \
> gcc fails compiling this.

I'm sorry.
The compile error was fixed at https://codereview.chromium.org/386933002/ .

Powered by Google App Engine
This is Rietveld 408576698