Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 385503002: Fixes for re-enabling more MSVC level 4 warnings: base/third_party/dmg_fp/ edition (Closed)

Created:
6 years, 5 months ago by Peter Kasting
Modified:
6 years, 5 months ago
Reviewers:
awong
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fixes for re-enabling more MSVC level 4 warnings: base/third_party/dmg_fp/ edition This contains fixes for the following sorts of issues: * Assignment inside conditional This updates the relevant .patch and README files, combining these fixes with the previous set of MSVC warning fixes. This also removes the now-unused vs2013-optimization.patch file. BUG=81439 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282280

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -74 lines) Patch
M base/third_party/dmg_fp/README.chromium View 1 chunk +1 line, -3 lines 0 comments Download
M base/third_party/dmg_fp/dtoa.cc View 19 chunks +60 lines, -36 lines 0 comments Download
M base/third_party/dmg_fp/g_fmt.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A base/third_party/dmg_fp/msvc_warnings.patch View 1 chunk +298 lines, -0 lines 0 comments Download
D base/third_party/dmg_fp/vs2013-optimization.patch View 1 chunk +0 lines, -18 lines 0 comments Download
D base/third_party/dmg_fp/win_vs2012.patch View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Kasting
6 years, 5 months ago (2014-07-10 00:13:13 UTC) #1
awong
LGTM
6 years, 5 months ago (2014-07-10 00:16:44 UTC) #2
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 5 months ago (2014-07-10 00:18:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/385503002/1
6 years, 5 months ago (2014-07-10 00:20:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 04:02:36 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 08:04:44 UTC) #6
Message was sent while issue was closed.
Change committed as 282280

Powered by Google App Engine
This is Rietveld 408576698