trunk/src/chrome/test/data/extensions/api_test/gcd_private/api/get_cloud_list.js - Issue 385483002: Probably broke Win7 Tests (dbg)(6). http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/test/data/extensions/api_test/gcd_private/api/get_cloud_list.js

Issue 385483002: Probably broke Win7 Tests (dbg)(6). http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%… (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « trunk/src/chrome/common/extensions/api/gcd_private.idl ('k') | trunk/src/chrome/test/data/extensions/api_test/gcd_private/api/receive_new_device.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: trunk/src/chrome/test/data/extensions/api_test/gcd_private/api/get_cloud_list.js

===================================================================

--- trunk/src/chrome/test/data/extensions/api_test/gcd_private/api/get_cloud_list.js (revision 282174)

+++ trunk/src/chrome/test/data/extensions/api_test/gcd_private/api/get_cloud_list.js (working copy)

@@ -8,13 +8,13 @@

chrome.gcdPrivate.getCloudDeviceList(function(services) {

// Sort to avoid order dependence

services.sort(function(a,b) {

- return a.deviceId.localeCompare(b.deviceId);

+ return a.idString.localeCompare(b.idString);

});

chrome.test.assertEq(2, services.length);

chrome.test.assertEq(services[0].setupType, "cloud");

- chrome.test.assertEq(services[0].deviceId,

+ chrome.test.assertEq(services[0].idString,

"cloudprint:someCloudPrintID");

chrome.test.assertEq(services[0].cloudId, "someCloudPrintID");

chrome.test.assertEq(services[0].deviceType, "printer");

@@ -24,7 +24,7 @@

"someCloudPrintDescription");

chrome.test.assertEq(services[1].setupType, "cloud");

- chrome.test.assertEq(services[1].deviceId, "gcd:someGCDID");

+ chrome.test.assertEq(services[1].idString, "gcd:someGCDID");

chrome.test.assertEq(services[1].cloudId, "someGCDID");

chrome.test.assertEq(services[1].deviceType, "someType");

chrome.test.assertEq(services[1].deviceName, "someGCDDisplayName");