Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 385433002: Push inverse device scale factor in DRLI->DRLI pushes (Closed)

Created:
6 years, 5 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

Push inverse device scale factor in DRLI->DRLI pushes DelegatedRendererLayerImpl computes an inverse device scale factor when receiving frame data so it can map from the delegating renderer's physical space to DIP space and then remap the quads from its renderer's DIP space to physical again. When using impl side painting, the frame is received by the DRLI on the pending tree. We need to push this factor to the active tree when pushing the passes so we can produce the correct quads from the active tree. BUG=382967 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282208

Patch Set 1 #

Total comments: 2

Patch Set 2 : dcheck->expect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M cc/layers/delegated_renderer_layer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jamesr
6 years, 5 months ago (2014-07-09 21:10:59 UTC) #1
danakj
LGTM thanks for the test https://codereview.chromium.org/385433002/diff/1/cc/layers/delegated_renderer_layer_impl_unittest.cc File cc/layers/delegated_renderer_layer_impl_unittest.cc (right): https://codereview.chromium.org/385433002/diff/1/cc/layers/delegated_renderer_layer_impl_unittest.cc#newcode1544 cc/layers/delegated_renderer_layer_impl_unittest.cc:1544: DCHECK_EQ(0.5f, delegated_renderer_layer_impl->inverse_device_scale_factor()); EXPECT_EQ https://codereview.chromium.org/385433002/diff/1/cc/layers/delegated_renderer_layer_impl_unittest.cc#newcode1551 ...
6 years, 5 months ago (2014-07-09 21:12:57 UTC) #2
jamesr
On 2014/07/09 21:12:57, danakj wrote: > LGTM thanks for the test > > https://codereview.chromium.org/385433002/diff/1/cc/layers/delegated_renderer_layer_impl_unittest.cc > ...
6 years, 5 months ago (2014-07-09 21:38:00 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 5 months ago (2014-07-09 22:17:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/385433002/20001
6 years, 5 months ago (2014-07-09 22:19:15 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-10 00:54:31 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 01:22:57 UTC) #7
Message was sent while issue was closed.
Change committed as 282208

Powered by Google App Engine
This is Rietveld 408576698