Issue 3854001: Merge 62674 - First round UI touch up of DOMUI based network menu....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3854001: Merge 62674 - First round UI touch up of DOMUI based network menu.... (Closed)

Created:
10 years, 2 months ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/552/src/

Visibility:
Public.

Merge 62674 - First round UI touch up of DOMUI based network menu. - Update network UI to make it closer to mocks; - Update menu.css to use default cursor; - Allow derived menu UI pass localized strings; BUG=chromium-os:7343 TEST=none. Review URL: http://codereview.chromium.org/3771003 TBR=stevenjb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62849

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+297 lines, -30 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_resources.grd	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/menu_ui.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/menu_ui.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/network_menu_ui.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/network_menu_ui.cc	View	4 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/browser/resources/menu.css	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/menu.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/menu.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chrome/browser/resources/network_menu.css	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/resources/network_menu.js	View	4 chunks	+254 lines, -28 lines	0 comments	Download

Total messages: 1 (0 generated)