Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 385333002: Update some Mac Bluetooth TODOs. (Closed)

Created:
6 years, 5 months ago by Ilya Sherman
Modified:
6 years, 5 months ago
Reviewers:
keybuk
CC:
chromium-reviews, armansito, rpaquay, xiyuan
Project:
chromium
Visibility:
Public.

Description

Update some Mac Bluetooth TODOs. BUG=none TEST=none R=keybuk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283356

Patch Set 1 #

Patch Set 2 : Remove debugging log stmts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M device/bluetooth/bluetooth_socket_mac.mm View 1 5 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
keybuk for OWNERS review, others as FYI and extra eyes. Unfortunately, all of these TODOs ...
6 years, 5 months ago (2014-07-12 05:54:50 UTC) #1
Ilya Sherman
On 2014/07/12 05:54:50, Ilya Sherman wrote: > For dynamically assigning PSMs and Channels, the situation ...
6 years, 5 months ago (2014-07-12 05:56:19 UTC) #2
keybuk
lgtm you could have totally TBRd this ;-)
6 years, 5 months ago (2014-07-15 20:36:52 UTC) #3
Ilya Sherman
On 2014/07/15 20:36:52, keybuk wrote: > lgtm > > you could have totally TBRd this ...
6 years, 5 months ago (2014-07-15 20:39:17 UTC) #4
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-15 20:39:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/385333002/20001
6 years, 5 months ago (2014-07-15 20:42:12 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 05:26:45 UTC) #7
Message was sent while issue was closed.
Change committed as 283356

Powered by Google App Engine
This is Rietveld 408576698