Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2622)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/about_memory_mac.html

Issue 38533006: Add a note in chrome://memory for other browsers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: does not --> don't Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/about_memory_linux.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/about_memory_mac.html
diff --git a/chrome/browser/resources/about_memory_mac.html b/chrome/browser/resources/about_memory_mac.html
index 57c7adb6bb1378080ba702923b08c40284014f0b..43e6272b039e864a2bf37203696663093fea8930 100644
--- a/chrome/browser/resources/about_memory_mac.html
+++ b/chrome/browser/resources/about_memory_mac.html
@@ -33,7 +33,7 @@ table.list#memoryDetails tr.firstRow th:nth-child(2) {
<script src="chrome://memory-redirect/strings.js"></script>
</head>
<body>
- <div id='header'>
+ <div id="header">
<h1>
About memory
</h1>
@@ -42,10 +42,10 @@ table.list#memoryDetails tr.firstRow th:nth-child(2) {
</p>
</div>
- <div id='content'>
+ <div id="content">
<h2>
Summary
- <div class='help'>
+ <div class="help">
<div>
<p>
Summary of memory used by currently active browsers.<p>
@@ -56,20 +56,20 @@ table.list#memoryDetails tr.firstRow th:nth-child(2) {
</div>
</h2>
- <table class='list' id='browserComparison'>
+ <table class="list" id="browserComparison">
<colgroup>
- <col class='name'>
- <col class='number'>
- <col class='number'>
- <col class='number'>
- <col class='number'>
+ <col class="name">
+ <col class="number">
+ <col class="number">
+ <col class="number">
+ <col class="number">
</colgroup>
- <tr class='firstRow doNotFilter'>
+ <tr class="firstRow doNotFilter">
<th>
</th>
- <th colspan='4'>
+ <th colspan="4">
Memory
- <div class='help'>
+ <div class="help">
<div>
<p>
<strong>Memory</strong>
@@ -101,45 +101,51 @@ table.list#memoryDetails tr.firstRow th:nth-child(2) {
</div>
</th>
</tr>
- <tr class='secondRow doNotFilter'>
- <th class='name'>
+ <tr class="secondRow doNotFilter">
+ <th class="name">
Browser
</th>
- <th class='number'>
+ <th class="number">
Resident
</th>
- <th class='number'>
+ <th class="number">
Shared
</th>
- <th class='number'>
+ <th class="number">
Private
</th>
- <th class='number'>
+ <th class="number">
Virtual
</th>
</tr>
<tr jsselect="browsers">
- <td class='name'>
+ <td class="name">
<div>
<strong jscontent="name"></strong> <span jscontent="version"></span>
</div>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_shareable)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_shareable)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_shared)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_shared)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_priv)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_priv)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(comm_priv)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(comm_priv)"></span><span class="k">k</span>
</td>
</tr>
</table>
- <div class=otherbrowsers jsdisplay="browsers.length == 1">
- Note: If other browsers (e.g., Safari, Firefox, Camino) are running, I'll show their memory details here.
+ <div class="otherbrowsers" jsdisplay="browsers.length == 1">
+ Note: If other browsers (e.g. Safari, Firefox, Camino) are running,
+ I'll show their memory details here.
arv (Not doing code reviews) 2013/10/30 16:58:02 "I'll show" sounds too colloquial. Is this what th
+ </div>
+ <div class="otherbrowsers" jsdisplay="browsers.length > 1">
+ Note: The memory details reported for some other browsers (e.g. Safari,
+ Firefox, Camino) typically don't include the memory used by plugins such
+ as Flash.
</div>
<div class="otherbrowsers">
(Bug: We seriously overcount our own memory usage: <a href="http://crbug.com/25454">Issue 25454</a>.)
@@ -149,7 +155,7 @@ table.list#memoryDetails tr.firstRow th:nth-child(2) {
<h2>
Processes
- <div class='help'>
+ <div class="help">
<div>
<p>
Details of memory usage for each of Chromium's processes.
@@ -158,93 +164,93 @@ table.list#memoryDetails tr.firstRow th:nth-child(2) {
</div>
</h2>
- <table class='list' id='memoryDetails'>
+ <table class="list" id="memoryDetails">
<colgroup>
- <col class='pid'>
- <col class='name'>
- <col class='number'>
- <col class='number'>
- <col class='number'>
- <col class='number'>
+ <col class="pid">
+ <col class="name">
+ <col class="number">
+ <col class="number">
+ <col class="number">
+ <col class="number">
</colgroup>
- <tr class='firstRow doNotFilter'>
+ <tr class="firstRow doNotFilter">
<th>
</th>
<th>
</th>
- <th colspan='4'>
+ <th colspan="4">
Memory
</th>
</tr>
- <tr class='secondRow doNotFilter'>
- <th class='pid'>
+ <tr class="secondRow doNotFilter">
+ <th class="pid">
PID
</th>
- <th class='name'>
+ <th class="name">
Name
</th>
- <th class='number'>
+ <th class="number">
Resident
</th>
- <th class='number'>
+ <th class="number">
Shared
</th>
- <th class='number'>
+ <th class="number">
Private
</th>
- <th class='number'>
+ <th class="number">
Virtual
</th>
</tr>
<tr jsselect="browzr_data">
- <td class='pid'>
- <span class='th' jscontent="pid"></span>
+ <td class="pid">
+ <span class="th" jscontent="pid"></span>
</td>
- <td class='name'>
+ <td class="name">
<div>
Browser
</div>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_shareable)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_shareable)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_shared)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_shared)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_priv)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_priv)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(comm_priv)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(comm_priv)"></span><span class="k">k</span>
</td>
</tr>
<tr jsselect="child_data">
- <td class='pid'>
- <span class='th' jscontent="pid"></span>
+ <td class="pid">
+ <span class="th" jscontent="pid"></span>
</td>
- <td class='name'>
+ <td class="name">
<div jscontent="child_name"></div>
<div jsselect="titles">
<span jscontent="$this"></span><br>
</div>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_shareable)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_shareable)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_shared)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_shared)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(ws_priv)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(ws_priv)"></span><span class="k">k</span>
</td>
- <td class='number'>
- <span class='th' jscontent="formatNumber(comm_priv)"></span><span class='k'>k</span>
+ <td class="number">
+ <span class="th" jscontent="formatNumber(comm_priv)"></span><span class="k">k</span>
</td>
</tr>
- <tr class='noResults'>
- <td colspan='99'>
+ <tr class="noResults">
+ <td colspan="99">
No results found.
</td>
</tr>
« no previous file with comments | « chrome/browser/resources/about_memory_linux.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698