Add a note in chrome://memory for other browsers

Add a note to describe that chrome://memory does not count
plug-ins' memory for other browsers, when other browsers run.


BUG=273316
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233495

[peria, 2013-10-24 07:37:51]

Hi Erik,
would you take a look, please?

[arv (Not doing code reviews), 2013-10-24 14:05:56]

LGTM

[peria, 2013-10-25 06:21:28]

On 2013/10/24 14:05:56, arv wrote:
> LGTM
Thank you for your review.


Kenji-san, would you check the sentences, just in case?

[peria, 2013-10-25 07:20:11]

Changed a review's address.

[kenjibaheux, 2013-10-25 07:37:05]

On 2013/10/25 07:20:11, peria wrote:
> Changed a review's address.

Could you change it to the following:
"Note:  the memory details reported for some other browsers (e.g. Firefox,
Safari) typically don't include the memory used by plugins such as Flash."

(does not => don't)

Also, could you confirm the following:
 1. this new note is shown when there is at least one additional browser being
measured.
 2. the old note is still shown when there is only one browser (guaranteed to be
Chrome/Chromium).


Thanks.

[peria, 2013-10-25 07:47:48]

> Could you change it to the following:
> "Note:  the memory details reported for some other browsers (e.g. Firefox,
> Safari) typically don't include the memory used by plugins such as Flash."

I want to check following details before editing.
1. Does the sentence start with lower case 't'? (The/the)
2. Do *2* spaces follow "Note:"?


> Also, could you confirm the following:
>  1. this new note is shown when there is at least one additional browser being
> measured.
>  2. the old note is still shown when there is only one browser (guaranteed to
be
> Chrome/Chromium).
I checked the behavior on Linux, with/without Firefox.
I'll do it again on Win/Mac.

[kenjibaheux, 2013-10-25 07:56:54]

> I want to check following details before editing.
> 1. Does the sentence start with lower case 't'? (The/the)

Sorry, uppercase T is correct
(http://en.wikipedia.org/wiki/Colon_(punctuation)#Use_of_capitals)
I guess I am used to English (UK) and European style where lowercase after colon
is the norm.


> 2. Do *2* spaces follow "Note:"?
Just one space.


> > Also, could you confirm the following:
> >  1. this new note is shown when there is at least one additional browser
being
> > measured.
> >  2. the old note is still shown when there is only one browser (guaranteed
to
> be
> > Chrome/Chromium).
> I checked the behavior on Linux, with/without Firefox.
> I'll do it again on Win/Mac.

Not all too familiar with jstemplate but I guess you would need to have
something like this:

[start]

<div class="otherbrowsers" jsdisplay="browsers.length > 1">Note: The memory
details reported for some other browsers (e.g. Firefox, Safari) typically don't
include the memory used by plugins such as Flash.</div>

<div class="otherbrowsers" jsdisplay="browsers.length == 1">Note: If other
browsers (e.g. IE, Firefox, Safari) are running, I'll show their memory details
here.</div>

[end]


Note the presence of 2 separate notes with different jsdisplay conditions
(exactly one browser shown; stricly more than one browser shown).

[peria, 2013-10-25 08:28:56]

I changed large number of lines.
Most of them are trivial, but would you review them again?

[kenjibaheux, 2013-10-25 11:10:39]

On 2013/10/25 08:28:56, peria wrote:
> I changed large number of lines.
> Most of them are trivial, but would you review them again?

I noticed that you have added IE to the list. For IE, Flash is in-process so
it's memory usage is reflected in the IE process.
However, I don't think it's a big deal because we use "typically" to qualify the
message.
 
LGTM but I defer to arv@ for the final word.

Thanks again!

[peria, 2013-10-30 09:23:12]

I'm sorry for late update.
Now I checked it works as expected on Windows, MacOSX, and Linux.

Eric, would you take a look again for the final word?

[arv (Not doing code reviews), 2013-10-30 16:58:01]

Not LGTM

https://codereview.chromium.org/38533006/diff/90001/chrome/browser/resources/...
File chrome/browser/resources/about_memory_mac.html (right):

https://codereview.chromium.org/38533006/diff/90001/chrome/browser/resources/...
chrome/browser/resources/about_memory_mac.html:143: I'll show their memory
details here.
"I'll show" sounds too colloquial. Is this what the UX designers want?

[kenjibaheux, 2013-10-30 19:28:23]

https://codereview.chromium.org/38533006/diff/90001/chrome/browser/resources/...
> chrome/browser/resources/about_memory_mac.html:143: I'll show their memory
> details here.
> "I'll show" sounds too colloquial. Is this what the UX designers want?

IIRC, the "I'll show" predates us. Nevertheless, let me take this opportunity to
run the strings by UX.

[kenjibaheux, 2013-11-01 01:26:55]

Note: sent a string review request

[peria, 2013-11-06 02:40:36]

Updated the notes as a UX designer Glen suggested.

[arv (Not doing code reviews), 2013-11-06 15:13:26]

LGTM

It is sad that we are repeating this in 3 places. Maybe in the future we could
use our preprocessor to get rid of the duplication? We have <if> and <include>
should be enough to do all we need here.

[peria, 2013-11-07 04:16:19]

Erik,
Thank you for reviewing!

I agree that we should not repeat the same work for 3 times.
I will work for refactoring of those files related to about:memory.



Kenji,
May I submit this CL now?

[kenjibaheux, 2013-11-07 05:25:14]

> Kenji,
> May I submit this CL now?

LGTM

[commit-bot: I haz the power, 2013-11-07 05:29:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peria@chromium.org/38533006/270001

[peria, 2013-11-07 05:30:01]

Thank you,
submitting.

[commit-bot: I haz the power, 2013-11-07 06:05:24]

Change committed as 233495