Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 385323002: Cleanup: Remove unused/unimplemented SkTextLayout.h. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup: Remove unused/unimplemented SkTextLayout.h. Nobody uses it in Skia, Chromium and Blink. And it does not have any implementation either. BUG=None TEST=make all R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/6599258a9902fb30007d7e5f5b3bc61f7208bebb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -272 lines) Patch
M gyp/public_headers.gypi View 2 chunks +211 lines, -212 lines 0 comments Download
D include/text/SkTextLayout.h View 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 5 months ago (2014-07-12 02:02:16 UTC) #1
reed1
lgtm
6 years, 5 months ago (2014-07-12 11:23:12 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-14 19:08:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/385323002/1
6 years, 5 months ago (2014-07-14 19:09:25 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 19:32:52 UTC) #5
Message was sent while issue was closed.
Change committed as 6599258a9902fb30007d7e5f5b3bc61f7208bebb

Powered by Google App Engine
This is Rietveld 408576698