Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 385283002: Roll gyp 1948:1950 (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll gyp 1948:1950 1950: Edited wiki page GypHacking through web user interface. 1949: Fixes two bugs in analyzer BUG=383609 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
6 years, 5 months ago (2014-07-11 20:11:35 UTC) #1
sky
6 years, 5 months ago (2014-07-11 20:11:45 UTC) #2
Mark Mentovai
LGTM
6 years, 5 months ago (2014-07-11 22:18:42 UTC) #3
Mark Mentovai
(I doubt the “subject” is correct but that doesn’t affect anything but e-mail…)
6 years, 5 months ago (2014-07-11 22:19:04 UTC) #4
sky
GAH!
6 years, 5 months ago (2014-07-11 22:21:50 UTC) #5
sky
The CQ bit was checked by sky@chromium.org
6 years, 5 months ago (2014-07-11 22:21:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/385283002/1
6 years, 5 months ago (2014-07-11 22:25:32 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 01:00:05 UTC) #8
Message was sent while issue was closed.
Change committed as 282763

Powered by Google App Engine
This is Rietveld 408576698