Issue 385263005: Gallery: Add support for Media Keys

Issue 385263005: Gallery: Add support for Media Keys (Closed)

Created:
6 years, 5 months ago by etrunko

Modified:
6 years, 5 months ago

Reviewers:
Bernhard Bauer, yoshiki

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, oshima+watch_chromium.org, nathan ciobanu

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Gallery: Add support for Media Keys BUG=393346 R=yoshiki@chromium.org R=bauerb@chromium.org TEST=Manually tested with external USB keyboard Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>; Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282954

Patch Set 2 : Adjust to 80 columns as suggested #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
M	ui/file_manager/gallery/js/gallery.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/file_manager/gallery/js/slide_mode.js	View	1	4 chunks	+10 lines, -1 line	0 comments	Download
M	ui/webui/resources/js/cr/ui/list_selection_controller.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yoshiki

lgtm with nit https://codereview.chromium.org/385263005/diff/1/ui/file_manager/gallery/js/slide_mode.js File ui/file_manager/gallery/js/slide_mode.js (right): https://codereview.chromium.org/385263005/diff/1/ui/file_manager/gallery/js/slide_mode.js#newcode610 ui/file_manager/gallery/js/slide_mode.js:610: var prev = (keyID === 'Up' ...

6 years, 5 months ago (2014-07-14 02:28:07 UTC) #2

etrunko

https://codereview.chromium.org/385263005/diff/1/ui/file_manager/gallery/js/slide_mode.js File ui/file_manager/gallery/js/slide_mode.js (right): https://codereview.chromium.org/385263005/diff/1/ui/file_manager/gallery/js/slide_mode.js#newcode610 ui/file_manager/gallery/js/slide_mode.js:610: var prev = (keyID === 'Up' || keyID === ...

6 years, 5 months ago (2014-07-14 13:27:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eduardo.lima@intel.com/385263005/10001

6 years, 5 months ago (2014-07-14 13:29:43 UTC) #6

Message was sent while issue was closed.

Change committed as 282954

Expand Messages | Collapse Messages