Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/content_settings/content_settings_default_provider_unittest.cc

Issue 385263004: Get rid of some uses of CreateIntegerValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/content_settings_default_provider_unittest.cc
diff --git a/chrome/browser/content_settings/content_settings_default_provider_unittest.cc b/chrome/browser/content_settings/content_settings_default_provider_unittest.cc
index 500d507cdea618e99a64dfb829200e14730e624a..c0a2f63ca8edaa20a7ec42a6ca349e0c9fb5031a 100644
--- a/chrome/browser/content_settings/content_settings_default_provider_unittest.cc
+++ b/chrome/browser/content_settings/content_settings_default_provider_unittest.cc
@@ -49,7 +49,7 @@ TEST_F(DefaultProviderTest, DefaultValues) {
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_COOKIES,
std::string(),
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
EXPECT_EQ(CONTENT_SETTING_BLOCK,
GetContentSetting(&provider_,
GURL(),
@@ -70,7 +70,7 @@ TEST_F(DefaultProviderTest, DefaultValues) {
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_GEOLOCATION,
std::string(),
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
EXPECT_EQ(CONTENT_SETTING_BLOCK,
GetContentSetting(&provider_,
GURL(),
@@ -101,7 +101,7 @@ TEST_F(DefaultProviderTest, IgnoreNonDefaultSettings) {
std::string(),
false));
scoped_ptr<base::Value> value(
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
bool owned = provider_.SetWebsiteSetting(
ContentSettingsPattern::FromURL(primary_url),
ContentSettingsPattern::FromURL(secondary_url),
@@ -129,7 +129,7 @@ TEST_F(DefaultProviderTest, Observer) {
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_IMAGES,
std::string(),
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
EXPECT_CALL(mock_observer,
OnContentSettingChanged(
@@ -139,7 +139,7 @@ TEST_F(DefaultProviderTest, Observer) {
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_GEOLOCATION,
std::string(),
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
}
@@ -155,7 +155,7 @@ TEST_F(DefaultProviderTest, ObserveDefaultPref) {
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_COOKIES,
std::string(),
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
EXPECT_EQ(CONTENT_SETTING_BLOCK,
GetContentSetting(&provider_,
GURL(),
@@ -213,7 +213,7 @@ TEST_F(DefaultProviderTest, OffTheRecord) {
ContentSettingsPattern::Wildcard(),
CONTENT_SETTINGS_TYPE_COOKIES,
std::string(),
- base::Value::CreateIntegerValue(CONTENT_SETTING_BLOCK));
+ new base::FundamentalValue(CONTENT_SETTING_BLOCK));
EXPECT_EQ(CONTENT_SETTING_BLOCK,
GetContentSetting(&provider_,
GURL(),
@@ -232,7 +232,7 @@ TEST_F(DefaultProviderTest, OffTheRecord) {
// Changing content settings on the incognito provider should be ignored.
scoped_ptr<base::Value> value(
- base::Value::CreateIntegerValue(CONTENT_SETTING_ALLOW));
+ new base::FundamentalValue(CONTENT_SETTING_ALLOW));
bool owned = otr_provider.SetWebsiteSetting(
ContentSettingsPattern::Wildcard(),
ContentSettingsPattern::Wildcard(),

Powered by Google App Engine
This is Rietveld 408576698