Issue 385263002: Refactor SkGrFontScaler and SkGrFontKey into non-virtual versions.

Issue 385263002: Refactor SkGrFontScaler and SkGrFontKey into non-virtual versions. (Closed)

Created:
6 years, 5 months ago by jvanverth1

Modified:
6 years, 5 months ago

Reviewers:
bsalomon, egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Refactor SkGrFontScaler and SkGrFontKey into non-virtual versions. This is a pre-cleanup for another change, but has the side benefit of making the code simpler in general. No perf increase, despite removing virtual functions. Committed: https://skia.googlesource.com/skia/+/733f5f5dbca10fc6385ec3c77b3e9ff78227dac7

Patch Set 1 #

Patch Set 2 : Restore SkCanvas #

Patch Set 3 : Remove more debug code #

Patch Set 4 : Rebase to ToT #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -360 lines)			Patch
M	gyp/gpu.gypi	View		4 chunks	+5 lines, -6 lines	0 comments	Download
M	include/gpu/GrFontScaler.h	View		1 chunk	+60 lines, -19 lines	0 comments	Download
D	include/gpu/GrKey.h	View		1 chunk	+0 lines, -38 lines	0 comments	Download
M	include/gpu/SkGr.h	View	1 2 3	2 chunks	+0 lines, -23 lines	0 comments	Download
A +	src/gpu/GrFontScaler.cpp	View		8 chunks	+17 lines, -35 lines	0 comments	Download
M	src/gpu/GrTextContext.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrTextStrike.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/GrTextStrike.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrTextStrike_impl.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	src/gpu/SkGrFontScaler.cpp	View		1 chunk	+0 lines, -231 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

jvanverth1

On 2014/07/11 19:24:12, bsalomon wrote: Was there a comment there?

6 years, 5 months ago (2014-07-11 19:33:45 UTC) #3

bsalomon

On 2014/07/11 19:33:45, jvanverth1 wrote: > On 2014/07/11 19:24:12, bsalomon wrote: > > Was there ...

6 years, 5 months ago (2014-07-11 19:38:23 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/385263002/60001

6 years, 5 months ago (2014-07-11 19:46:52 UTC) #6

commit-bot: I haz the power

6 years, 5 months ago (2014-07-12 02:45:22 UTC) #7

Message was sent while issue was closed.

Change committed as 733f5f5dbca10fc6385ec3c77b3e9ff78227dac7

Expand Messages | Collapse Messages