Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385213002: Update system_memory to use results.AddValue (Closed)

Created:
6 years, 5 months ago by nednguyen
Modified:
6 years, 5 months ago
Reviewers:
eakuefner, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update system_memory to use results.AddValue BUG=391943 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M tools/perf/metrics/system_memory.py View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 5 months ago (2014-07-11 16:36:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/385213002/1
6 years, 5 months ago (2014-07-11 16:37:29 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-11 16:37:30 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-11 16:37:30 UTC) #4
nednguyen
6 years, 5 months ago (2014-07-11 16:50:35 UTC) #5
tonyg
lgtm
6 years, 5 months ago (2014-07-11 16:53:14 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 19:20:53 UTC) #7
Message was sent while issue was closed. 
Change committed as 282661

Powered by Google App Engine
This is Rietveld 408576698