Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 385173009: Remove ASSERT since there are tons of different ASSIGN variants (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2410 matching lines...) Expand 10 before | Expand all | Expand 10 after
2421 __ mov(edx, location); 2421 __ mov(edx, location);
2422 __ cmp(edx, isolate()->factory()->the_hole_value()); 2422 __ cmp(edx, isolate()->factory()->the_hole_value());
2423 __ j(not_equal, &assign, Label::kNear); 2423 __ j(not_equal, &assign, Label::kNear);
2424 __ push(Immediate(var->name())); 2424 __ push(Immediate(var->name()));
2425 __ CallRuntime(Runtime::kThrowReferenceError, 1); 2425 __ CallRuntime(Runtime::kThrowReferenceError, 1);
2426 __ bind(&assign); 2426 __ bind(&assign);
2427 EmitStoreToStackLocalOrContextSlot(var, location); 2427 EmitStoreToStackLocalOrContextSlot(var, location);
2428 2428
2429 } else if (!var->is_const_mode() || op == Token::INIT_CONST) { 2429 } else if (!var->is_const_mode() || op == Token::INIT_CONST) {
2430 if (var->IsLookupSlot()) { 2430 if (var->IsLookupSlot()) {
2431 ASSERT(op == Token::ASSIGN || op == Token::INIT_VAR ||
2432 op == Token::ASSIGN_ADD);
2433 // Assignment to var. 2431 // Assignment to var.
2434 __ push(eax); // Value. 2432 __ push(eax); // Value.
2435 __ push(esi); // Context. 2433 __ push(esi); // Context.
2436 __ push(Immediate(var->name())); 2434 __ push(Immediate(var->name()));
2437 __ push(Immediate(Smi::FromInt(strict_mode()))); 2435 __ push(Immediate(Smi::FromInt(strict_mode())));
2438 __ CallRuntime(Runtime::kStoreLookupSlot, 4); 2436 __ CallRuntime(Runtime::kStoreLookupSlot, 4);
2439 } else { 2437 } else {
2440 // Assignment to var or initializing assignment to let/const in harmony 2438 // Assignment to var or initializing assignment to let/const in harmony
2441 // mode. 2439 // mode.
2442 ASSERT(var->IsStackAllocated() || var->IsContextSlot()); 2440 ASSERT(var->IsStackAllocated() || var->IsContextSlot());
(...skipping 2355 matching lines...) Expand 10 before | Expand all | Expand 10 after
4798 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4796 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4799 Assembler::target_address_at(call_target_address, 4797 Assembler::target_address_at(call_target_address,
4800 unoptimized_code)); 4798 unoptimized_code));
4801 return OSR_AFTER_STACK_CHECK; 4799 return OSR_AFTER_STACK_CHECK;
4802 } 4800 }
4803 4801
4804 4802
4805 } } // namespace v8::internal 4803 } } // namespace v8::internal
4806 4804
4807 #endif // V8_TARGET_ARCH_IA32 4805 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698