DevTools: move UI components to target observers in preparation to early UI initialization.

Source/devtools/front_end/elements/RenderingOptionsView.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
+ * @implements {WebInspector.TargetManager.Observer}
  */
 WebInspector.RenderingOptionsView = function()
 {
     WebInspector.VBox.call(this);
     this.registerRequiredCSS("helpScreen.css");
     this.element.classList.add("help-indent-labels");
 
     var div = this.element.createChild("div", "settings-tab help-content help-container help-no-columns");
     div.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Show paint rectangles"), WebInspector.settings.showPaintRects));
     div.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Show composited layer borders"), WebInspector.settings.showDebugBorders));
     div.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Show FPS meter"), WebInspector.settings.showFPSCounter));
     div.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Enable continuous page repainting"), WebInspector.settings.continuousPainting));
-    var child = WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Show potential scroll bottlenecks"), WebInspector.settings.showScrollBottleneckRects);
+    var child = WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Show potential scroll bottlenecks"), WebInspector.settings.settings.showScrollBottleneckRects);

[dgozman, 2014/07/14 12:16:11]

Accidental change?

[pfeldman, 2014/07/14 12:41:20]

Done.

     child.title = WebInspector.UIString("Shows areas of the page that slow down scrolling:\nTouch and mousewheel event listeners can delay scrolling.\nSome areas need to repaint their content when scrolled.");
     div.appendChild(child);
+
+    /**
+     * @type {!Map.<!WebInspector.Setting, function(boolean)>}
+     */
+    this._setters = new Map();
+    this._mapSettingToSetter(WebInspector.settings.showPaintRects, Protocol.PageAgent.prototype.setShowPaintRects);
+    this._mapSettingToSetter(WebInspector.settings.showDebugBorders, Protocol.PageAgent.prototype.setShowDebugBorders);
+    this._mapSettingToSetter(WebInspector.settings.showFPSCounter, Protocol.PageAgent.prototype.setShowFPSCounter);
+    this._mapSettingToSetter(WebInspector.settings.continuousPainting, Protocol.PageAgent.prototype.setContinuousPaintingEnabled);
+    this._mapSettingToSetter(WebInspector.settings.showScrollBottleneckRects, Protocol.PageAgent.prototype.setShowScrollBottleneckRects);
+
+    WebInspector.targetManager.observeTargets(this);
 }
 
 WebInspector.RenderingOptionsView.prototype = {
+    /**
+     * @param {!WebInspector.Target} target
+     */
+    targetAdded: function(target)
+    {
+        var settings = this._setters.keys();
+        for (var i = 0; i < settings.length; ++i) {
+            var setting = settings[i];
+            if (setting.get()) {
+                var setter = this._setters.get(setting);
+                setter.call(target.pageAgent(), true);

[dgozman, 2014/07/14 12:16:11]

This means that settings will not be applied unless Elements module is loaded.

[pfeldman, 2014/07/14 12:41:20]

Done.

+            }
+        }
+    },
+
+    /**
+     * @param {!WebInspector.Target} target
+     */
+    targetRemoved: function(target)
+    {
+    },
+
+    /**
+     * @param {!WebInspector.Setting} setting
+     * @param {function(boolean)} setter
+     */
+    _mapSettingToSetter: function(setting, setter)
+    {
+        this._setters.put(setting, setter);
+        setting.addChangeListener(changeListener.bind(this));
+
+        /**
+         * @this {WebInspector.RenderingOptionsView}
+         */
+        function changeListener()
+        {
+            var targets = WebInspector.targetManager.targets();
+            var setter = this._setters.get(setting);
+            for (var i = 0; i < targets.length; ++i)
+                setter.call(targets[i].pageAgent(), setting.get());
+        }
+    },
+
     __proto__: WebInspector.VBox.prototype
 }