Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 385173007: DevTools: move UI components to target observers in preparation to early UI initialization. (Closed)

Created:
6 years, 5 months ago by pfeldman
Modified:
6 years, 5 months ago
Reviewers:
caseq, dgozman, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: move UI components to target observers in preparation to early UI initialization. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178060

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : Review comments addressed. #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -174 lines) Patch
M Source/devtools/devtools.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/common/ModuleManager.js View 5 chunks +8 lines, -5 lines 0 comments Download
M Source/devtools/front_end/common/Settings.js View 3 chunks +7 lines, -66 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/RenderingOptionsView.js View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
M Source/devtools/front_end/elements/module.json View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/main/AdvancedApp.js View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A + Source/devtools/front_end/main/RenderingOptions.js View 1 2 2 chunks +62 lines, -2 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 4 chunks +30 lines, -27 lines 0 comments Download
M Source/devtools/front_end/toolbox/MediaQueryInspector.js View 4 chunks +32 lines, -5 lines 0 comments Download
M Source/devtools/front_end/toolbox/ResponsiveDesignView.js View 3 chunks +25 lines, -1 line 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pfeldman
6 years, 5 months ago (2014-07-14 12:06:30 UTC) #1
dgozman
https://codereview.chromium.org/385173007/diff/20001/Source/devtools/front_end/elements/RenderingOptionsView.js File Source/devtools/front_end/elements/RenderingOptionsView.js (right): https://codereview.chromium.org/385173007/diff/20001/Source/devtools/front_end/elements/RenderingOptionsView.js#newcode47 Source/devtools/front_end/elements/RenderingOptionsView.js:47: var child = WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Show potential scroll bottlenecks"), WebInspector.settings.settings.showScrollBottleneckRects); Accidental ...
6 years, 5 months ago (2014-07-14 12:16:11 UTC) #2
pfeldman
https://codereview.chromium.org/385173007/diff/20001/Source/devtools/front_end/elements/RenderingOptionsView.js File Source/devtools/front_end/elements/RenderingOptionsView.js (right): https://codereview.chromium.org/385173007/diff/20001/Source/devtools/front_end/elements/RenderingOptionsView.js#newcode47 Source/devtools/front_end/elements/RenderingOptionsView.js:47: var child = WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Show potential scroll bottlenecks"), WebInspector.settings.settings.showScrollBottleneckRects); On ...
6 years, 5 months ago (2014-07-14 12:41:20 UTC) #3
caseq
https://codereview.chromium.org/385173007/diff/40001/Source/devtools/front_end/main/RenderingOptions.js File Source/devtools/front_end/main/RenderingOptions.js (right): https://codereview.chromium.org/385173007/diff/40001/Source/devtools/front_end/main/RenderingOptions.js#newcode41 Source/devtools/front_end/main/RenderingOptions.js:41: this._mapSettingToSetter(WebInspector.settings.showPaintRects, "setShowPaintRects"); It's quite unfortunate to loose types here. ...
6 years, 5 months ago (2014-07-14 12:47:09 UTC) #4
pfeldman
> It's quite unfortunate to loose types here. Why don't we keep functions in the ...
6 years, 5 months ago (2014-07-14 12:48:24 UTC) #5
dgozman
lgtm
6 years, 5 months ago (2014-07-14 13:09:47 UTC) #6
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-14 13:12:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/385173007/40001
6 years, 5 months ago (2014-07-14 13:13:14 UTC) #8
pfeldman
The CQ bit was unchecked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-14 13:16:55 UTC) #9
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-14 13:24:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/385173007/60001
6 years, 5 months ago (2014-07-14 13:24:40 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 14:37:25 UTC) #12
Message was sent while issue was closed. 
Change committed as 178060

Powered by Google App Engine
This is Rietveld 408576698