Issue 385173003: Fix the issue that webview-browser-sample crashed on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385173003: Fix the issue that webview-browser-sample crashed on Mac. (Closed)

Created:
6 years, 5 months ago by Xi Han

Modified:
6 years, 5 months ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

The crash is caused when a guest is attached, a parameter "repaint" is passed in. For most device, their scale factor is 1, so we don't need to repaint and "repaint" is set to false. However, for high dpi devices like Mac, the scale factor is 2, rather than 1. Therefore, a DECHECK of the scale factor == 1 is failed. So we use GetDeviceScaleFactor() to initialize last_device_scale_factor as well. BUG=393278 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282711

Patch Set 1 #

Patch Set 2 : Update the initialition of last_device_scale_factor. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/browser_plugin/browser_plugin.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hanxi@chromium.org/385173003/20001

6 years, 5 months ago (2014-07-11 20:41:11 UTC) #5

Message was sent while issue was closed.

Change committed as 282711

Expand Messages | Collapse Messages