Some fixes to avoid breakages when enabling out-of-line constant pools.

Some fixes to avoid breakages when enabling out-of-line constant pools.

Three fixes which are required to pass all the tests when  out-of-line constant
pools are enabled for Arm:

 - Invalidate embedded objects in optimized code when it is deoptimized such
   that the weak pointers in the constant pool array are cleared.  This prevents
   a CHECK(heap_->mark_compact_collector()->IsMarked(object)) error when a
   verifying weak pointers in a deoptimized code object's constant pool.
 - Modify LargeObjectSpace::Verify to allow constant pool arrays in the
   large object space.
 - Increase the 32bit stack size limit, since the constant pool pointer
   is now on every stack frame, causing the size of each stack frame to
   increase by one word, and causing deep-recursion-test to fail.

R=hpayer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22445

[rmcilroy, 2014-07-11 16:39:23]

Thanks for finding the InvalidateEmbeddedObjects fix Ulan!  There were a couple
of other things which needed fixing.  The logs for the failing builds which
these changes fix are:

http://build.chromium.org/p/client.v8/builders/V8%20Arm%20GC%20Stress/builds/...

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim...

http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/12...

PTAL, thanks.

https://codereview.chromium.org/385163005/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/385163005/diff/1/src/flag-definitions.h#newco...
src/flag-definitions.h:461: DEFINE_INT(stack_size, 984,
Note: this could be lower for 32bit, but I would still need to be larger than
512KB, which would mean that 64bit would be larger than 1MB if calculated based
on kPointerSize, so I have just set it to be the same as the existing 64bit
limit.  Let me know if you would prefer it set differently.

[rmcilroy, 2014-07-15 15:06:01]

It seems I forgot to add you to the review... oops.  Original message below:


Thanks for finding the InvalidateEmbeddedObjects fix Ulan!  There were a couple
of other things which needed fixing.  The logs for the failing builds which
these changes fix are:

http://build.chromium.org/p/client.v8/builders/V8%20Arm%20GC%20Stress/builds/...

http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim...

http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug/builds/12...

PTAL, thanks.

[rmcilroy, 2014-07-15 17:42:56]

Hannes: looks like Ulan is OOO until August - could you please take a look at
this CL?

[Hannes Payer (out of office), 2014-07-16 15:23:28]

lgtm

https://codereview.chromium.org/385163005/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/385163005/diff/1/src/flag-definitions.h#newco...
src/flag-definitions.h:461: DEFINE_INT(stack_size, 984,
On 2014/07/11 16:39:23, rmcilroy wrote:
> Note: this could be lower for 32bit, but I would still need to be larger than
> 512KB, which would mean that 64bit would be larger than 1MB if calculated
based
> on kPointerSize, so I have just set it to be the same as the existing 64bit
> limit.  Let me know if you would prefer it set differently.

I guess it is fine, I do not have a strong opinion there.

https://codereview.chromium.org/385163005/diff/1/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/385163005/diff/1/src/spaces.cc#newcode3065
src/spaces.cc:3065: // strings), fixed arrays, byte arrays and constant pool
arrays in the
"," before and

[rmcilroy, 2014-07-16 15:30:40]

https://codereview.chromium.org/385163005/diff/1/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/385163005/diff/1/src/spaces.cc#newcode3065
src/spaces.cc:3065: // strings), fixed arrays, byte arrays and constant pool
arrays in the
On 2014/07/16 15:23:28, Hannes Payer wrote:
> "," before and

https://www.youtube.com/watch?v=P_i1xk07o4g :)

Done.

[rmcilroy, 2014-07-17 10:03:37]

Committed patchset #2 manually as r22445 (presubmit successful).