Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 385163004: Revert of Remove gpu shader optimatization for solid white or trans black colors (Closed)

Created:
6 years, 5 months ago by egdaniel
Modified:
6 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Remove gpu shader optimatization for solid white or trans black colors (https://codereview.chromium.org/375823005/) Reason for revert: possible test and gm failures Original issue's description: > Remove gpu shader optimatization for solid white or trans black colors > > Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths. > > With optimization in (ms): > White Blue Checkered > Linux ~80 ~80 ~160 > N7 ~800 ~1100 ~1500 > Moto-e ~830 ~1100 ~2500 > > Without optimization in (ms): > White Blue Checkered > Linux ~80 ~80 ~80 > N7 ~1100 ~1100 ~1100 > Moto-e ~1100 ~1100 ~1500 > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/5f78d2251a440443c9eaa321dad058d7a32bfef7 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c855ca0c9408d2a218655a138fab9cc18a2b3940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -204 lines) Patch
D bench/AlternatingColorPatternBench.cpp View 1 chunk +0 lines, -199 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +13 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
egdaniel
Created Revert of Remove gpu shader optimatization for solid white or trans black colors
6 years, 5 months ago (2014-07-11 16:12:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/385163004/1
6 years, 5 months ago (2014-07-11 16:13:32 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 16:13:40 UTC) #3
Message was sent while issue was closed.
Change committed as c855ca0c9408d2a218655a138fab9cc18a2b3940

Powered by Google App Engine
This is Rietveld 408576698