Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 385146: [Linux] Hide fullscreen bubble when kiosk mode is active. (Closed)

Created:
11 years, 1 month ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
tony, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

[Linux] Hide fullscreen bubble when kiosk mode is active. When chrome is ran in kiosk mode, the fullscreen bubble should be hidden. As well, I found a major variable name mixup in browerview. BUG=27308 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32151

Patch Set 1 #

Total comments: 2

Patch Set 2 : Forgot import, make try happy #

Patch Set 3 : Indent 2 spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/browser/gtk/browser_window_gtk.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mohamed Mansour
11 years, 1 month ago (2009-11-17 00:17:31 UTC) #1
tony
LGTM, just a question below. http://codereview.chromium.org/385146/diff/1/2 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/385146/diff/1/2#newcode1023 Line 1023: return fullscreen_exit_bubble_.get() ? ...
11 years, 1 month ago (2009-11-17 00:19:48 UTC) #2
Mohamed Mansour
http://codereview.chromium.org/385146/diff/1/2 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/385146/diff/1/2#newcode1023 Line 1023: return fullscreen_exit_bubble_.get() ? true : false; On 2009/11/17 ...
11 years, 1 month ago (2009-11-17 00:36:37 UTC) #3
tony
11 years, 1 month ago (2009-11-17 00:39:12 UTC) #4
I see, this matches the Views code.

Ok, LGTM.

Powered by Google App Engine
This is Rietveld 408576698