Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 385143002: ServiceWorker: Stop a worker thread on unregistration (Closed)

Created:
6 years, 5 months ago by nhiroki
Modified:
6 years, 5 months ago
Reviewers:
falken, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Stop a worker thread on unregistration ServiceWorker is designed to delay stopping the worker thread (30 sec) when all controlled documents are closed so that the next navigation can save the startup time. In the current code, this improvement also applies to the unregistration with no controllees, but in that case we should immediately stop the thread because the worker doesn't work anymore. BUG=392735, 393127 TEST=content_unittests --gtest_filter=ServiceWorker* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282922

Patch Set 1 #

Patch Set 2 : modify unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M content/browser/service_worker/service_worker_job_unittest.cc View 1 3 chunks +10 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nhiroki
Is this reasonable change? If so, I'll make a test. Thanks!
6 years, 5 months ago (2014-07-11 09:40:09 UTC) #1
falken
Yep this looks right. Also relevant is https://github.com/slightlyoff/ServiceWorker/issues/346
6 years, 5 months ago (2014-07-12 05:51:01 UTC) #2
nhiroki
Thanks for your comment. Updated and removed WIP mark. Can you take another look?
6 years, 5 months ago (2014-07-14 04:22:03 UTC) #3
falken
On 2014/07/14 04:22:03, nhiroki wrote: > Thanks for your comment. Updated and removed WIP mark. ...
6 years, 5 months ago (2014-07-14 07:27:34 UTC) #4
nhiroki
On 2014/07/14 07:27:34, falken wrote: > On 2014/07/14 04:22:03, nhiroki wrote: > > Thanks for ...
6 years, 5 months ago (2014-07-14 07:32:07 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 5 months ago (2014-07-14 07:33:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/385143002/20001
6 years, 5 months ago (2014-07-14 07:34:07 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 09:16:00 UTC) #8
Message was sent while issue was closed.
Change committed as 282922

Powered by Google App Engine
This is Rietveld 408576698