tools/perf/benchmarks/jetstream.py - Issue 385133005: Update jetstream to use results.AddValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/jetstream.py

Issue 385133005: Update jetstream to use results.AddValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/jetstream.py

diff --git a/tools/perf/benchmarks/jetstream.py b/tools/perf/benchmarks/jetstream.py

index 98c4349eb18b9820f5e719b353b7c044d28a79e9..1b029500c7756116cb61fc8850b389486b7841f1 100644

--- a/tools/perf/benchmarks/jetstream.py

+++ b/tools/perf/benchmarks/jetstream.py

@@ -60,8 +60,9 @@ class _JetstreamMeasurement(page_measurement.PageMeasurement):

all_scores = []

for k, v in result.iteritems():

- results.Add(k.replace('.', '_'), 'score', v['result'],

- data_type='unimportant')

+ results.AddValue(scalar.ScalarValue(

+ results.current_page, k.replace('.', '_'), 'score', v['result'],

+ important=False))

# Collect all test scores to compute geometric mean.

all_scores.extend(v['result'])

total = statistics.GeometricMean(all_scores)

« no previous file with comments | « no previous file | no next file » | no next file with comments »