Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 385123008: Update recursedeps to support use_relative_path. (Closed)

Created:
6 years, 5 months ago by cmp
Modified:
6 years, 5 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, epoger
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Update recursedeps to support use_relative_path. Also cast recursedeps to a set. We'll continue to support using a list literal form in DEPS for now. R=iannucci@chromium.org,agable@chromium.org BUG=393000 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=283474

Patch Set 1 #

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M gclient.py View 2 chunks +13 lines, -1 line 0 comments Download
M tests/gclient_test.py View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cmp
6 years, 5 months ago (2014-07-11 22:41:58 UTC) #1
cmp
ping
6 years, 5 months ago (2014-07-15 18:57:11 UTC) #2
agable
lgtm
6 years, 5 months ago (2014-07-16 16:34:41 UTC) #3
cmp
Plan to land this afternoon.
6 years, 5 months ago (2014-07-16 17:38:50 UTC) #4
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 5 months ago (2014-07-16 19:45:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmp@chromium.org/385123008/20001
6 years, 5 months ago (2014-07-16 19:46:50 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 19:48:56 UTC) #7
Message was sent while issue was closed.
Change committed as 283474

Powered by Google App Engine
This is Rietveld 408576698