Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 385123006: cc: Use ExpandRectIgnoringBordersToTileBoundsWithBordersEmpty. (Closed)

Created:
6 years, 5 months ago by danakj
Modified:
6 years, 5 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

cc: Use ExpandRectIgnoringBordersToTileBoundsWithBordersEmpty. When expanding the live tiles rect, we want to include border pixels for all tiles that intersect the live tiles rect. It used to do this by also including any tiles whose border pixels intersect the live tiles rect, but that's excessive. This adds ExpandRectIgnoringBordersToTileBoundsWithBordersEmpty and uses it to expand the live tiles rect, the unit test PictureLayerTilingIteratorTest.ResizeOverBorderPixelsDeletesTiles covers this usage of the method. The ExpandRectToTileBoundsWithBorders is no longer used, so remove it. R=enne BUG=386998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -40 lines) Patch
M cc/base/tiling_data.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/base/tiling_data.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M cc/base/tiling_data_unittest.cc View 3 chunks +43 lines, -30 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danakj
Depends on https://codereview.chromium.org/387613002/
6 years, 5 months ago (2014-07-11 21:26:36 UTC) #1
enne (OOO)
lgtm
6 years, 5 months ago (2014-07-11 23:05:44 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 5 months ago (2014-07-14 01:22:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/385123006/1
6 years, 5 months ago (2014-07-14 01:23:10 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 03:07:33 UTC) #5
Message was sent while issue was closed.
Change committed as 282896

Powered by Google App Engine
This is Rietveld 408576698