Apply andrewbunn's patch for issue 19358

Apply andrewbunn's patch for issue 19358

The patch gives non-webapp chrome an app id so that win7 taskbar group the icons correctly. That is, webapp icons are grouped together based on app name and all chrome windows are grouped together.

BUG=19358
TEST=verify fix for issue 19358

[xiyuan, 2009-11-14 19:53:59]

Tried andrewbunn's patch on Win7 which fixes issue 1935.

The only thing missing now is that running web app and its pinned icon on
taskbar are separate. After my CL to create shortcut natively gets in, I'll make
change to tag the shortcut with a proper app id to solve the problem.

[brg, 2009-11-16 19:12:00]

LGTM.

[Hironori Bono, 2009-11-17 06:13:39]

LGTM.
Nevertheless, to change the application ID of non-application window, we need to
change some other code that relies on this application ID, e.g. JumpList, etc.
I'm going to write a follow-up change to do it.

Regards,

Hironori Bono

[xiyuan, 2009-11-17 20:39:01]

+hbono

hbono, please also take a look to make sure it does not get in your way.

On Sat, Nov 14, 2009 at 11:53 AM, <xiyuan@chromium.org> wrote:

> Reviewers: brg,
>
> Message:
> Tried andrewbunn's patch on Win7 which fixes issue 1935.
>
> The only thing missing now is that running web app and its pinned icon on
> taskbar are separate. After my CL to create shortcut natively gets in, I'll
> make
> change to tag the shortcut with a proper app id to solve the problem.
>
> Description:
> Apply andrewbunn's patch for issue 19358
>
> The patch gives non-webapp chrome an app id so that win7 taskbar group the
> icons
> correctly. That is, webapp icons are grouped together based on app name and
> all
> chrome windows are grouped together.
>
> BUG=19358
> TEST=verify fix for issue 19358
>
> Please review this at http://codereview.chromium.org/385120
>
> Affected files:
>  M chrome/browser/browser.cc
>
>
> Index: chrome/browser/browser.cc
> diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
> index
>
ebca6656fa3757af450ba6be2db65e86da6ce3c0..14fe317bda2db0b8f9047281a123d2d1dc6dfd74
> 100644
> --- a/chrome/browser/browser.cc
> +++ b/chrome/browser/browser.cc
> @@ -229,6 +229,14 @@ void Browser::CreateBrowserWindow() {
>
>   window_ = BrowserWindow::CreateBrowserWindow(this);
>
> +#if defined(OS_WIN)
> +  // Set the app user model id for this application to that of the
> application
> +  // name.  See http://crbug.com/7028.
> +  win_util::SetAppIdForWindow(type_ & TYPE_APP ? app_name_ :
> +                              l10n_util::GetString(IDS_PRODUCT_NAME),
> +                              window()->GetNativeHandle());
> +#endif
> +
>   NotificationService::current()->Notify(
>       NotificationType::BROWSER_WINDOW_READY,
>       Source<Browser>(this),
> @@ -316,12 +324,6 @@ void Browser::OpenApplicationWindow(Profile* profile,
> const GURL& url) {
>   browser->AddTabWithURL(url, GURL(), PageTransition::START_PAGE, true, -1,
>                          false, NULL);
>
> -#if defined(OS_WIN)
> -  // Set the app user model id for this application to that of the
> application
> -  // name.  See http://crbug.com/7028.
> -  win_util::SetAppIdForWindow(app_name,
> browser->window()->GetNativeHandle());
> -#endif
> -
>   TabContents* tab_contents = browser->GetSelectedTabContents();
>   tab_contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
>   tab_contents->render_view_host()->SyncRendererPrefs();
>
>
>

[xiyuan, 2009-11-17 20:39:01]

Sounds good. I'll do the follow up CL for pinned shortcut.

On Mon, Nov 16, 2009 at 10:13 PM, <hbono@chromium.org> wrote:

> LGTM.
> Nevertheless, to change the application ID of non-application window, we
> need to
> change some other code that relies on this application ID, e.g. JumpList,
> etc.
> I'm going to write a follow-up change to do it.
>
> Regards,
>
> Hironori Bono
>
>
> http://codereview.chromium.org/385120
>