Issue 385113003: Revert 282546 "Enforce SafetyMode for YouTube if prefs::kForceSa..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385113003: Revert 282546 "Enforce SafetyMode for YouTube if prefs::kForceSa..." (Closed)

Created:
6 years, 5 months ago by kustermann

Modified:
6 years, 5 months ago

Reviewers:
Marc Treib

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 282546 "Enforce SafetyMode for YouTube if prefs::kForceSa..." Reason for revert: [0711/004616:ERROR:unit_test_launcher.cc(360)] no test result for SafeSearchUtilTest.ModifyYoutubePrefCookie [ RUN ] SafeSearchUtilTest.ModifyYoutubePrefCookie c:\b\depot_tools\win_toolchain\vs2013_files\vc\include\xstring(79) : Assertion failed: string iterator not dereferencable c:\b\depot_tools\win_toolchain\vs2013_files\vc\include\xstring(80) : Assertion failed: "Standard C++ Libraries Out of Range" && 0 [7000/7003] SafeSearchUtilTest.ModifyYoutubePrefCookie (UNKNOWN) > Enforce SafetyMode for YouTube if prefs::kForceSafeSearch is on, by modifying (or adding) YouTube's PrefCookie in the HTTP header. > > This is essentially a followup to https://codereview.chromium.org/11186002/ > > BUG=344815 > > Review URL: https://codereview.chromium.org/354183002 TBR=treib@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282601

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+127 lines, -490 lines)			Patch
M	trunk/src/chrome/browser/extensions/api/web_request/web_request_api_helpers.cc	View	4 chunks	+66 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/net/chrome_network_delegate.cc	View	6 chunks	+60 lines, -8 lines	0 comments	Download
D	trunk/src/chrome/browser/net/safe_search_util.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	trunk/src/chrome/browser/net/safe_search_util.cc	View	1 chunk	+0 lines, -195 lines	0 comments	Download
D	trunk/src/chrome/browser/net/safe_search_util_unittest.cc	View	1 chunk	+0 lines, -90 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/net/cookies/cookie_util.h	View	2 chunks	+1 line, -22 lines	0 comments	Download
M	trunk/src/net/cookies/cookie_util.cc	View	1 chunk	+0 lines, -53 lines	0 comments	Download
M	trunk/src/net/cookies/cookie_util_unittest.cc	View	2 chunks	+0 lines, -85 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r282601.

Expand Messages | Collapse Messages