Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 385103: Moved the various Google Accounts URLs out of gaia_login.html and into sync_s... (Closed)

Created:
11 years, 1 month ago by idana
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, idana
Visibility:
Public.

Description

Moved the various Google Accounts URLs out of gaia_login.html and into sync_setup_wizard.cc so that we can append the language code as a CGI parameter based on the locale. BUG=26385 TEST=Make sure links on the sync login dialog open pages in the same language as the browser language.

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M chrome/browser/sync/resources/gaia_login.html View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard.cc View 1 2 4 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
idana
11 years, 1 month ago (2009-11-13 22:09:13 UTC) #1
idana
11 years, 1 month ago (2009-11-13 22:11:38 UTC) #2
tim (not reviewing)
LGTM with one nit http://codereview.chromium.org/385103/diff/7/1001 File chrome/browser/sync/sync_setup_wizard.cc (right): http://codereview.chromium.org/385103/diff/7/1001#newcode173 Line 173: return std::string(localized_url.spec()); 'return localized_url.spec();'
11 years, 1 month ago (2009-11-13 22:25:16 UTC) #3
idana
http://codereview.chromium.org/385103/diff/7/1001 File chrome/browser/sync/sync_setup_wizard.cc (right): http://codereview.chromium.org/385103/diff/7/1001#newcode173 Line 173: return std::string(localized_url.spec()); On 2009/11/13 22:25:16, timsteele wrote: > ...
11 years, 1 month ago (2009-11-13 23:29:47 UTC) #4
tim (not reviewing)
Did you check this in?
11 years, 1 month ago (2009-11-19 17:44:39 UTC) #5
idana
11 years, 1 month ago (2009-11-19 19:14:24 UTC) #6
Yes

On Thu, Nov 19, 2009 at 9:44 AM, <tim@chromium.org> wrote:

> Did you check this in?
>
>
>
> http://codereview.chromium.org/385103
>



-- 
-Idan

Powered by Google App Engine
This is Rietveld 408576698