Port most of browser action apitest to linux.

Port most of browser action apitest to linux.

BUG=27224
committed r32085

[Evan Stade, 2009-11-13 22:59:40]

+tony

[tony, 2009-11-13 23:07:36]

Is it possible to add view ids to the windows side so we can try to share a bit
of code (I realize it's not really that much sharing)?  Or maybe have interfaces
for some of these classes?  I'm mostly worried about when we want to test mac.

[Evan Stade, 2009-11-13 23:15:42]

it doesn't seem worth it to add an interface just for testing. In some cases
like the LocationBar there is a cross-platform interface but it's actually
useful in places besides testing. So I'd rather keep the production code cleaner
at the cost of less succinct test cases.

Note how (advantageously) I didn't have to touch the actual implementation at
all to write this test. On Windows, they did, even to the extent that the
BrowserActionButtonView is public instead of internal to the
BrowserActionContainer. There are also public functions of the form
TestGetProperty, which seems very wrong (should be private function + test
friended). So I think the Windows side could use cleaning up, but that is a
separate issue.

[tony, 2009-11-14 00:27:18]

LG, however, I still think there should be an interface for this.  The fact that
interfaces make it easier to test seems like enough reason to me.  Going
forward, there will likely be less maintenance issues if we have an interface. 
It also means that mac will get the tests with less effort.

On 2009/11/13 23:15:42, Evan Stade wrote:
> it doesn't seem worth it to add an interface just for testing. In some cases
> like the LocationBar there is a cross-platform interface but it's actually
> useful in places besides testing. So I'd rather keep the production code
cleaner
> at the cost of less succinct test cases.
> 
> Note how (advantageously) I didn't have to touch the actual implementation at
> all to write this test. On Windows, they did, even to the extent that the
> BrowserActionButtonView is public instead of internal to the
> BrowserActionContainer. There are also public functions of the form
> TestGetProperty, which seems very wrong (should be private function + test
> friended). So I think the Windows side could use cleaning up, but that is a
> separate issue.

[Aaron Boodman, 2009-11-14 00:50:18]

Delegating the review to Tony since he already started.

Thanks a lot for doing this, Evan.