Issue 385076: Correctly get ExtensionService out of EXTENSION_PROCESS_CRASHED notification....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 385076: Correctly get ExtensionService out of EXTENSION_PROCESS_CRASHED notification.... (Closed)

Created:
11 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Correctly get ExtensionService out of EXTENSION_PROCESS_CRASHED notification. Source is Profile*, not ExtensionsService*. BUG=27199 TEST=load gmail browser action extension, crash it with task manager, press reload button. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31826

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

LGTM I had to break that with my earlier patch. :-( Could you verify by ...

11 years, 1 month ago (2009-11-12 21:16:38 UTC) #2

Evan Stade

11 years, 1 month ago (2009-11-12 21:18:40 UTC) #3

On Thu, Nov 12, 2009 at 1:16 PM,  <phajdan.jr@chromium.org> wrote:
> LGTM
>
> I had to break that with my earlier patch. :-( Could you verify by git grep
> that
> there are no other instances of that mistake?

the only other observer is the task manager and it doesn't care about
the Source (only the Details)

>
> Ideal thing to do would be to write a test that crashes an extension and
> restores it.
>
> http://codereview.chromium.org/385076
>

Expand Messages | Collapse Messages