Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 385073010: Revert 282697 "Non-SFI NaCl: Fix browser_tests based on libc_free.c" (Closed)

Created:
6 years, 5 months ago by mmenke
Modified:
6 years, 5 months ago
Reviewers:
hamaji
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 282697 "Non-SFI NaCl: Fix browser_tests based on libc_free.c" This broke LSAN. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/9737/steps/compile/logs/stdio > Non-SFI NaCl: Fix browser_tests based on libc_free.c > > There were two issues with clang: > > - Clang emits .data.rel.ro.local for local struct values with > an initializer, which lets the linker to emit a few > relocation info. > - In debug build, clang uses memcpy to copy a structure with > five members. Neither -fno-builtin nor -ffreestanding did > not prevent this issue. > - In release build, clang translates for-loop based zero copy > to memset. > > This patch initializes all structures without initializers > or copy. This patch works with GYP_DEFINES=clang=0. > > To make sure we will not add memcpy or something in future, > we will build libc_free.nexe with -Wl,--no-undefined. > > This also reverts > > https://codereview.chromium.org/386543002 > > to enable the disabled tests. > > BUG=392768 > TEST=./out/Debug/browser_tests --gtest_filter='*NonSfi*Messaging*' > > Review URL: https://codereview.chromium.org/381883002 TBR=hamaji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M trunk/src/chrome/test/data/nacl/nacl_test_data.gyp View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/chrome/test/data/nacl/nonsfi/libc_free.c View 1 chunk +18 lines, -11 lines 0 comments Download
M trunk/src/chrome/test/nacl/nacl_browsertest.cc View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
6 years, 5 months ago (2014-07-11 21:18:12 UTC) #1
mmenke
6 years, 5 months ago (2014-07-11 21:18:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r282702 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698