Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/x64/ic-x64.cc

Issue 385073007: Revert "Use the same registers for StoreIC and KeyedStoreIC." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1047 matching lines...) Expand 10 before | Expand all | Expand 10 after
1058 const Register KeyedStoreIC::NameRegister() { 1058 const Register KeyedStoreIC::NameRegister() {
1059 return StoreIC::NameRegister(); 1059 return StoreIC::NameRegister();
1060 } 1060 }
1061 1061
1062 1062
1063 const Register KeyedStoreIC::ValueRegister() { 1063 const Register KeyedStoreIC::ValueRegister() {
1064 return StoreIC::ValueRegister(); 1064 return StoreIC::ValueRegister();
1065 } 1065 }
1066 1066
1067 1067
1068 const Register KeyedStoreIC::MapRegister() {
1069 return rbx;
1070 }
1071
1072
1073 void KeyedLoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm) { 1068 void KeyedLoadIC::GenerateRuntimeGetProperty(MacroAssembler* masm) {
1074 // The return address is on the stack. 1069 // The return address is on the stack.
1075 1070
1076 __ PopReturnAddressTo(KeyedLoadIC_TempRegister()); 1071 __ PopReturnAddressTo(KeyedLoadIC_TempRegister());
1077 __ Push(ReceiverRegister()); // receiver 1072 __ Push(ReceiverRegister()); // receiver
1078 __ Push(NameRegister()); // name 1073 __ Push(NameRegister()); // name
1079 __ PushReturnAddressFrom(KeyedLoadIC_TempRegister()); 1074 __ PushReturnAddressFrom(KeyedLoadIC_TempRegister());
1080 1075
1081 // Perform tail call to the entry. 1076 // Perform tail call to the entry.
1082 __ TailCallRuntime(Runtime::kKeyedGetProperty, 2, 1); 1077 __ TailCallRuntime(Runtime::kKeyedGetProperty, 2, 1);
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
1277 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1272 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1278 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1273 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1279 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1274 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1280 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1275 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1281 } 1276 }
1282 1277
1283 1278
1284 } } // namespace v8::internal 1279 } } // namespace v8::internal
1285 1280
1286 #endif // V8_TARGET_ARCH_X64 1281 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698