Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 385073007: Revert "Use the same registers for StoreIC and KeyedStoreIC." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1276 matching lines...) Expand 10 before | Expand all | Expand 10 after
1287 Register* StoreStubCompiler::registers() { 1287 Register* StoreStubCompiler::registers() {
1288 // receiver, name, scratch1, scratch2, scratch3. 1288 // receiver, name, scratch1, scratch2, scratch3.
1289 Register receiver = StoreIC::ReceiverRegister(); 1289 Register receiver = StoreIC::ReceiverRegister();
1290 Register name = StoreIC::NameRegister(); 1290 Register name = StoreIC::NameRegister();
1291 static Register registers[] = { receiver, name, r3, r4, r5 }; 1291 static Register registers[] = { receiver, name, r3, r4, r5 };
1292 return registers; 1292 return registers;
1293 } 1293 }
1294 1294
1295 1295
1296 Register* KeyedStoreStubCompiler::registers() { 1296 Register* KeyedStoreStubCompiler::registers() {
1297 // receiver, name, scratch1/map, scratch2, scratch3. 1297 // receiver, name, scratch1, scratch2, scratch3.
1298 Register receiver = KeyedStoreIC::ReceiverRegister(); 1298 Register receiver = KeyedStoreIC::ReceiverRegister();
1299 Register name = KeyedStoreIC::NameRegister(); 1299 Register name = KeyedStoreIC::NameRegister();
1300 Register map = KeyedStoreIC::MapRegister(); 1300 static Register registers[] = { receiver, name, r3, r4, r5 };
1301 static Register registers[] = { receiver, name, map, r4, r5 };
1302 return registers; 1301 return registers;
1303 } 1302 }
1304 1303
1305 1304
1306 #undef __ 1305 #undef __
1307 #define __ ACCESS_MASM(masm) 1306 #define __ ACCESS_MASM(masm)
1308 1307
1309 1308
1310 void LoadStubCompiler::GenerateLoadViaGetter(MacroAssembler* masm, 1309 void LoadStubCompiler::GenerateLoadViaGetter(MacroAssembler* masm,
1311 Handle<HeapType> type, 1310 Handle<HeapType> type,
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
1391 if (check == PROPERTY && 1390 if (check == PROPERTY &&
1392 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) { 1391 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) {
1393 __ cmp(this->name(), Operand(name)); 1392 __ cmp(this->name(), Operand(name));
1394 __ b(ne, &miss); 1393 __ b(ne, &miss);
1395 } 1394 }
1396 1395
1397 Label number_case; 1396 Label number_case;
1398 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss; 1397 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
1399 __ JumpIfSmi(receiver(), smi_target); 1398 __ JumpIfSmi(receiver(), smi_target);
1400 1399
1401 // Polymorphic keyed stores may use the map register
1402 Register map_reg = scratch1(); 1400 Register map_reg = scratch1();
1403 ASSERT(kind() != Code::KEYED_STORE_IC ||
1404 map_reg.is(KeyedStoreIC::MapRegister()));
1405 1401
1406 int receiver_count = types->length(); 1402 int receiver_count = types->length();
1407 int number_of_handled_maps = 0; 1403 int number_of_handled_maps = 0;
1408 __ ldr(map_reg, FieldMemOperand(receiver(), HeapObject::kMapOffset)); 1404 __ ldr(map_reg, FieldMemOperand(receiver(), HeapObject::kMapOffset));
1409 for (int current = 0; current < receiver_count; ++current) { 1405 for (int current = 0; current < receiver_count; ++current) {
1410 Handle<HeapType> type = types->at(current); 1406 Handle<HeapType> type = types->at(current);
1411 Handle<Map> map = IC::TypeToMap(*type, isolate()); 1407 Handle<Map> map = IC::TypeToMap(*type, isolate());
1412 if (!map->is_deprecated()) { 1408 if (!map->is_deprecated()) {
1413 number_of_handled_maps++; 1409 number_of_handled_maps++;
1414 __ mov(ip, Operand(map)); 1410 __ mov(ip, Operand(map));
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
1506 1502
1507 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1503 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1508 } 1504 }
1509 1505
1510 1506
1511 #undef __ 1507 #undef __
1512 1508
1513 } } // namespace v8::internal 1509 } } // namespace v8::internal
1514 1510
1515 #endif // V8_TARGET_ARCH_ARM 1511 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698