chrome/test/data/extensions/api_test/popup_api/toolband.html - Issue 385061: experimental.popup support for tab-content-viewed extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/popup_api/toolband.html

Issue 385061: experimental.popup support for tab-content-viewed extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/data/extensions/api_test/popup_api/toolband.html

===================================================================

--- chrome/test/data/extensions/api_test/popup_api/toolband.html (revision 31907)

+++ chrome/test/data/extensions/api_test/popup_api/toolband.html (working copy)

@@ -1,5 +1,6 @@

+<html xmlns="http://www.w3.org/1999/xhtml">

+<head>

var globalValue = "I am not 42.";

window.onload = function() {

@@ -42,16 +43,20 @@

function closePopup() {

chrome.test.listenOnce(chrome.experimental.popup.onClosed, function(){

- chrome.test.assertTrue(

- chrome.experimental.extension.getPopupView() == undefined);

+ // TODO(twiz): getPopupView() should return undefined, but, due to

+ // shut-down races, it is sometimes still defined. See BUG

+ //chrome.test.assertTrue(

+ // chrome.experimental.extension.getPopupView() == undefined);

});

chrome.experimental.extension.getPopupView().close();

}

]);

}

</script>

+</head>

<body>

<div>

</div>

</body>

+</html>