experimental.popup support for tab-content-viewed extensions

chrome/renderer/resources/extension_process_bindings.js

 // Copyright (c) 2009 The chrome Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetExtensionAPIDefinition();
   native function StartRequest();
   native function GetCurrentPageActions(extensionId);
   native function GetExtensionViews();
   native function GetChromeHidden();
   native function GetNextRequestId();
   native function OpenChannelToTab();
   native function GetRenderViewId();
   native function GetL10nMessage();
-  native function GetPopupAnchorView();
+  native function GetPopupParentWindow();
   native function GetPopupView();
   native function SetExtensionActionIcon();
 
   if (!chrome)
     chrome = {};
 
   var chromeHidden = GetChromeHidden();
 
   // Validate arguments.
   chromeHidden.validationTypes = [];
@@ skipping 189 matching lines @@
     return {
       top: curtop,
       left: curleft
     };
   }
 
   // Returns the coordiates of the rectangle encompassing the domElement,
   // in browser coordinates relative to the frame hosting the element.
   function getAbsoluteRect(domElement) {
     var rect = findAbsolutePosition(domElement);
-    rect.width = domElement.width || 0;
-    rect.height = domElement.height || 0;
+    rect.width = domElement.offsetWidth || 0;
+    rect.height = domElement.offsetHeight || 0;
     return rect;
   }
 
   // --- Setup additional api's not currently handled in common/extensions/api
 
   // Page action events send (pageActionId, {tabId, tabUrl}).
   function setupPageActionEvents(extensionId) {
     var pageActions = GetCurrentPageActions(extensionId);
 
     var oldStyleEventName = "pageActions/" + extensionId;
@@ skipping 69 matching lines @@
           if (module[functionDef.name])
             return;
 
           var apiFunction = {};
           apiFunction.definition = functionDef;
           apiFunction.name = apiDef.namespace + "." + functionDef.name;;
           apiFunctions[apiFunction.name] = apiFunction;
 
           module[functionDef.name] = bind(apiFunction, function() {
             chromeHidden.validate(arguments, this.definition.parameters);
-            
+
             var retval;
-            if (this.handleRequest)
+            if (this.handleRequest) {
               retval = this.handleRequest.apply(this, arguments);
-            else
+            } else {
               retval = sendRequest(this.name, arguments,
-                                 this.definition.parameters);
+                                   this.definition.parameters);
+            }
 
             // Validate return value if defined - only in debug.
             if (chromeHidden.validateCallbacks &&
                 chromeHidden.validate &&
                 this.definition.returns) {
               chromeHidden.validate([retval], [this.definition.returns]);
             }
             return retval;
           });
         });
@@ skipping 75 matching lines @@
       return tabIdProxy;
     }
 
     apiFunctions["i18n.getMessage"].handleRequest =
         function(message_name, placeholders) {
       return GetL10nMessage(message_name, placeholders);
     }
 
     apiFunctions["experimental.popup.show"].handleRequest =
         function(url, showDetails, callback) {
-      var internalArgs = [url, getAbsoluteRect(showDetails.relativeTo),
-          callback];
-      return sendRequest(this.name, internalArgs, this.definition.parameters);
+      // Second argument is a transform from HTMLElement to Rect.
+      var internalSchema = [
+        this.definition.parameters[0],
+        {
+          type: "object",
+          name: "domAnchor",
+          properties: {
+            top: { type: "integer", minimum: 0 },
+            left: { type: "integer", minimum: 0 },
+            width: { type: "integer", minimum: 0 },
+            height: { type: "integer", minimum: 0 }
+          }
+        },
+        this.definition.parameters[2]
+      ];
+      return sendRequest(this.name,
+                         [url,
+                          getAbsoluteRect(showDetails.relativeTo),
+                          callback],
+                         internalSchema);
     }
 
     apiFunctions["experimental.extension.getPopupView"].handleRequest =
         function() {
       return GetPopupView();
     }
 
-    apiFunctions["experimental.popup.getAnchorWindow"].handleRequest =
+    apiFunctions["experimental.popup.getParentWindow"].handleRequest =
         function() {
-      return GetPopupAnchorView();
+      return GetPopupParentWindow();
     }
 
     var canvas;
     function setIconCommon(details, name, parameters) {
       var EXTENSION_ACTION_ICON_SIZE = 19;
 
       if ("iconIndex" in details) {
         sendRequest(name, [details], parameters);
       } else if ("imageData" in details) {
         // Verify that this at least looks like an ImageData element.
@@ skipping 72 matching lines @@
     AUTO_SUBFRAME: 3,
     MANUAL_SUBFRAME: 4,
     GENERATED: 5,
     START_PAGE: 6,
     FORM_SUBMIT: 7,
     RELOAD: 8,
     KEYWORD: 9,
     KEYWORD_GENERATED: 10
   };
 })();