"Am I on the right thread?" DCHECKs for StatusBubbleMac....

"Am I on the right thread?" DCHECKs for StatusBubbleMac.

This doesn't fix bug 26979, but I want to get these DCHECKs in as I continue
to investigate that bug.

BUG=26979
TEST=don't hit these DCHECKs

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31695

[Mark Mentovai, 2009-11-11 19:25:44]

Reviewers: pink,

Description:
"Am I on the right thread?" DCHECKs for StatusBubbleMac.

This doesn't fix bug 26979, but I want to get these DCHECKs in as I continue
to investigate that bug.

BUG=26979
TEST=don't hit these DCHECKs

Please review this at http://codereview.chromium.org/385043

SVN Base: svn://svn.chromium.org/chrome/trunk/src/

Affected files:
   M     chrome/browser/cocoa/status_bubble_mac.mm


Index: chrome/browser/cocoa/status_bubble_mac.mm
===================================================================
--- chrome/browser/cocoa/status_bubble_mac.mm	(revision 31667)
+++ chrome/browser/cocoa/status_bubble_mac.mm	(working copy)
@@ -343,6 +343,7 @@
  }

  void StatusBubbleMac::AnimationDidStop(CAAnimation* animation, bool  
finished) {
+  DCHECK([NSThread isMainThread]);
    DCHECK(state_ == kBubbleShowingFadeIn || state_ == kBubbleHidingFadeOut);

    if (finished) {
@@ -352,10 +353,10 @@
      // properly synchronized.
      if (state_ == kBubbleShowingFadeIn) {
        DCHECK_EQ([[window_ animator] alphaValue], kBubbleOpacity);
-      state_ = kBubbleShown;
+      SetState(kBubbleShown);
      } else {
        DCHECK_EQ([[window_ animator] alphaValue], 0.0);
-      state_ = kBubbleHidden;
+      SetState(kBubbleHidden);
      }
    }
  }
@@ -371,6 +372,8 @@
  }

  void StatusBubbleMac::Fade(bool show) {
+  DCHECK([NSThread isMainThread]);
+
    StatusBubbleState fade_state = kBubbleShowingFadeIn;
    StatusBubbleState target_state = kBubbleShown;
    NSTimeInterval full_duration = kShowFadeInDurationSeconds;
@@ -414,6 +417,7 @@
  }

  void StatusBubbleMac::StartTimer(int64 delay_ms) {
+  DCHECK([NSThread isMainThread]);
    DCHECK(state_ == kBubbleShowingTimer || state_ == kBubbleHidingTimer);

    if (immediate_) {
@@ -431,12 +435,15 @@
  }

  void StatusBubbleMac::CancelTimer() {
+  DCHECK([NSThread isMainThread]);
+
    if (!timer_factory_.empty())
      timer_factory_.RevokeAll();
  }

  void StatusBubbleMac::TimerFired() {
    DCHECK(state_ == kBubbleShowingTimer || state_ == kBubbleHidingTimer);
+  DCHECK([NSThread isMainThread]);

    if (state_ == kBubbleShowingTimer) {
      SetState(kBubbleShowingFadeIn);

[TVL, 2009-11-11 19:40:35]

drive by: lgtm

[TVL, 2009-11-11 19:40:54]

drive by: lgtm

http://codereview.chromium.org/385043

[pink (ping after 24hrs), 2009-11-11 19:47:44]

LGTM. Can't hurt.

[pink (ping after 24hrs), 2009-11-11 19:48:07]

LGTM. Can't hurt.

http://codereview.chromium.org/385043