Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 385043: "Am I on the right thread?" DCHECKs for StatusBubbleMac.... (Closed)

Created:
11 years, 1 month ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

"Am I on the right thread?" DCHECKs for StatusBubbleMac. This doesn't fix bug 26979, but I want to get these DCHECKs in as I continue to investigate that bug. BUG=26979 TEST=don't hit these DCHECKs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/cocoa/status_bubble_mac.mm View 5 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark Mentovai
11 years, 1 month ago (2009-11-11 19:25:26 UTC) #1
Mark Mentovai
Reviewers: pink, Description: "Am I on the right thread?" DCHECKs for StatusBubbleMac. This doesn't fix ...
11 years, 1 month ago (2009-11-11 19:25:44 UTC) #2
TVL
drive by: lgtm
11 years, 1 month ago (2009-11-11 19:40:35 UTC) #3
TVL
drive by: lgtm http://codereview.chromium.org/385043
11 years, 1 month ago (2009-11-11 19:40:54 UTC) #4
pink (ping after 24hrs)
LGTM. Can't hurt.
11 years, 1 month ago (2009-11-11 19:47:44 UTC) #5
pink (ping after 24hrs)
11 years, 1 month ago (2009-11-11 19:48:07 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698