Propagate the "first party for cookies" from WebKit through the resource...

webkit/glue/resource_loader_bridge.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The intent of this file is to provide a type-neutral abstraction between
 // Chrome and WebKit for resource loading. This pure-virtual interface is
 // implemented by the embedder, which also provides a factory method Create
 // to instantiate this object.
 //
 // One of these objects will be created by WebKit for each request. WebKit
 // will own the pointer to the bridge, and will delete it when the request is
 // no longer needed.
 //
 // In turn, the bridge's owner on the WebKit end will implement the Peer
 // interface, which we will use to communicate notifications back.
 
-#ifndef RESOURCE_LOADER_BRIDGE_H_
-#define RESOURCE_LOADER_BRIDGE_H_
+#ifndef WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_
+#define WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_
 
 #include "build/build_config.h"
 #if defined(OS_POSIX)
 #include "base/file_descriptor_posix.h"
 #endif
 #include "base/platform_file.h"
 #include "base/ref_counted.h"
 #include "base/time.h"
 #include "googleurl/src/gurl.h"
 #include "net/url_request/url_request_status.h"
@@ skipping 74 matching lines @@
    public:
     virtual ~Peer() {}
 
     // Called as upload progress is made.
     // note: only for requests with LOAD_ENABLE_UPLOAD_PROGRESS set
     virtual void OnUploadProgress(uint64 position, uint64 size) = 0;
 
     // Called when a redirect occurs.  The implementation may return false to
     // suppress the redirect.  The given ResponseInfo provides complete
     // information about the redirect, and new_url is the URL that will be
-    // loaded if this method returns true.
+    // loaded if this method returns true.  If this method returns true, it
+    // stores in *new_first_party_for_cookies the new URL that should be
+    // consulted for the third-party cookie blocking policy.  If the cookie
+    // policy URL doesn't need changing, it stores an empty, invalid URL in
+    // *new_first_party_for_cookies.
     virtual bool OnReceivedRedirect(const GURL& new_url,
-                                    const ResponseInfo& info) = 0;
+                                    const ResponseInfo& info,
+                                    GURL* new_first_party_for_cookies) = 0;

[darin (slow to review), 2009/11/16 17:59:50]

nit: down below, this is called the "policy_url" ...

it would be good to either name this new_policy_url, or rename policy_url to
first_party_for_cookies.

[wtc, 2009/11/16 20:25:58]

I will rename policy_url to first_party_for_cookies in
the declaration of the Create() method below, because
the two definitions of the Create() method (in
renderer_glue.cc and simple_resource_loader_bridge.cc)
name this parameter first_party_for_cookies.

I found that both policy_url and first_party_for_cookies
are used in many places.  This inconsistency of parameter
name is unfortunate.

 
     // Called when response headers are available (after all redirects have
     // been followed).  |content_filtered| is set to true if the contents is
     // altered or replaced (usually for security reasons when the resource is
     // deemed unsafe).
     virtual void OnReceivedResponse(const ResponseInfo& info,
                                     bool content_filtered) = 0;
 
     // Called when a chunk of response data is available. This method may
     // be called multiple times or not at all if an error occurs.
@@ skipping 99 matching lines @@
  protected:
   // construction must go through Create()
   ResourceLoaderBridge();
 
  private:
   DISALLOW_EVIL_CONSTRUCTORS(ResourceLoaderBridge);
 };
 
 }  // namespace webkit_glue
 
-#endif  // RESOURCE_LOADER_BRIDGE_
+#endif  // WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_