Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 385013004: make gs_utils.py class-based, so credentials file can be read just once (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

make gs_utils.py class-based, so credentials file can be read just once BUG=skia:2618 R=rmistry@google.com Committed: https://skia.googlesource.com/common/+/b38d520

Patch Set 1 #

Total comments: 8

Patch Set 2 : Ravi comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -123 lines) Patch
M py/utils/gs_utils.py View 1 4 chunks +126 lines, -123 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
epoger
Ravi- Please review at patchset 1. The Rietveld diff makes this change look bigger than ...
6 years, 5 months ago (2014-07-14 15:36:42 UTC) #1
rmistry
LGTM https://codereview.chromium.org/385013004/diff/1/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/385013004/diff/1/py/utils/gs_utils.py#newcode54 py/utils/gs_utils.py:54: allow the caller to operate on public files. ...
6 years, 5 months ago (2014-07-14 17:41:50 UTC) #2
epoger
6 years, 5 months ago (2014-07-14 17:56:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as rb38d520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698