Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/component_updater/crx_downloader.cc

Issue 385013002: Componentize component_updater: Replace content::BrowserThread usage with task runners (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extraneous includes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/crx_downloader.cc
diff --git a/chrome/browser/component_updater/crx_downloader.cc b/chrome/browser/component_updater/crx_downloader.cc
index a70211ae35551a8ea2c32bbcd1c624103cdd3b39..65ae360c5da06bbeb2acca51225e6a3c5f62f01c 100644
--- a/chrome/browser/component_updater/crx_downloader.cc
+++ b/chrome/browser/component_updater/crx_downloader.cc
@@ -3,15 +3,16 @@
// found in the LICENSE file.
#include "chrome/browser/component_updater/crx_downloader.h"
+
+#include "base/logging.h"
+#include "base/sequenced_task_runner.h"
+#include "base/single_thread_task_runner.h"
#include "chrome/browser/component_updater/url_fetcher_downloader.h"
-#include "content/public/browser/browser_thread.h"
#if defined(OS_WIN)
#include "chrome/browser/component_updater/background_downloader_win.h"
#endif
-using content::BrowserThread;
-
namespace component_updater {
CrxDownloader::Result::Result()
@@ -31,16 +32,16 @@ CrxDownloader::DownloadMetrics::DownloadMetrics()
CrxDownloader* CrxDownloader::Create(
bool is_background_download,
net::URLRequestContextGetter* context_getter,
- scoped_refptr<base::SequencedTaskRunner> task_runner) {
+ scoped_refptr<base::SequencedTaskRunner> url_fetcher_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> background_task_runner) {
scoped_ptr<CrxDownloader> url_fetcher_downloader(
new UrlFetcherDownloader(scoped_ptr<CrxDownloader>().Pass(),
context_getter,
- task_runner));
+ url_fetcher_task_runner));
#if defined(OS_WIN)
if (is_background_download) {
- return new BackgroundDownloader(url_fetcher_downloader.Pass(),
- context_getter,
- task_runner);
+ return new BackgroundDownloader(
+ url_fetcher_downloader.Pass(), context_getter, background_task_runner);
}
#endif
@@ -49,7 +50,6 @@ CrxDownloader* CrxDownloader::Create(
CrxDownloader::CrxDownloader(scoped_ptr<CrxDownloader> successor)
: successor_(successor.Pass()) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
}
CrxDownloader::~CrxDownloader() {
@@ -85,7 +85,7 @@ void CrxDownloader::StartDownloadFromUrl(
void CrxDownloader::StartDownload(const std::vector<GURL>& urls,
const DownloadCallback& download_callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK(thread_checker_.CalledOnValidThread());
if (urls.empty()) {
// Make a result and complete the download with a generic error for now.
@@ -110,7 +110,7 @@ void CrxDownloader::OnDownloadComplete(
bool is_handled,
const Result& result,
const DownloadMetrics& download_metrics) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK(thread_checker_.CalledOnValidThread());
download_metrics_.push_back(download_metrics);
@@ -147,7 +147,7 @@ void CrxDownloader::OnDownloadComplete(
}
void CrxDownloader::OnDownloadProgress(const Result& result) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK(thread_checker_.CalledOnValidThread());
if (progress_callback_.is_null())
return;
« no previous file with comments | « chrome/browser/component_updater/crx_downloader.h ('k') | chrome/browser/component_updater/default_component_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698