Componentize component_updater: Replace content::BrowserThread usage with task runners

chrome/browser/component_updater/component_updater_service.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 20 matching lines @@
 namespace component_updater {
 
 class Configurator;
 class OnDemandUpdater;
 
 // Component specific installers must derive from this class and implement
 // OnUpdateError() and Install(). A valid instance of this class must be
 // given to ComponentUpdateService::RegisterComponent().
 class ComponentInstaller {
  public:
-  // Called by the component updater on the UI thread when there was a
+  // Called by the component updater on the main thread when there was a
   // problem unpacking or verifying the component. |error| is a non-zero
   // value which is only meaningful to the component updater.
   virtual void OnUpdateError(int error) = 0;
 
   // Called by the component updater when a component has been unpacked
   // and is ready to be installed. |manifest| contains the CRX manifest
   // json dictionary and |unpack_path| contains the temporary directory
-  // with all the unpacked CRX files.
+  // with all the unpacked CRX files. This method is called from a task runner.

[blundell, 2014/07/15 08:45:20]

"from a task runner" is not particularly informative here.

[tommycli, 2014/07/15 18:58:25]

Done.

   virtual bool Install(const base::DictionaryValue& manifest,
                        const base::FilePath& unpack_path) = 0;
 
   // Set |installed_file| to the full path to the installed |file|. |file| is
   // the filename of the file in this component's CRX. Returns false if this is
   // not possible (the file has been removed or modified, or its current
   // location is unknown). Otherwise, returns true.
   virtual bool GetInstalledFile(const std::string& file,
                                 base::FilePath* installed_file) = 0;
 
@@ skipping 29 matching lines @@
 // to package extensions. To the update service each component is identified
 // by its public key hash (CrxComponent::pk_hash). If there is an update
 // available and its version is bigger than (CrxComponent::version), it will
 // be downloaded, verified and unpacked. Then component-specific installer
 // ComponentInstaller::Install (of CrxComponent::installer) will be called.
 //
 // During the normal operation of the component updater some specific
 // notifications are fired, like COMPONENT_UPDATER_STARTED and
 // COMPONENT_UPDATE_FOUND. See notification_type.h for more details.
 //
-// All methods are safe to call ONLY from chrome's UI thread.
+// All methods are safe to call ONLY from the browser's main thread.
 class ComponentUpdateService {
  public:
   enum Status { kOk, kReplaced, kInProgress, kError };
 
   // Defines an interface to observe ComponentUpdateService. It provides
   // notifications when state changes occur for the service or for the
   // registered components.
   class Observer {
    public:
     enum Events {
@@ skipping 101 matching lines @@
       const std::string& component_id) = 0;
 };
 
 // Creates the component updater. You must pass a valid |config| allocated on
 // the heap which the component updater will own.
 ComponentUpdateService* ComponentUpdateServiceFactory(Configurator* config);
 
 }  // namespace component_updater
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_UPDATER_SERVICE_H_