extensions/renderer/dom_activity_logger.cc - Issue 384983003: Enabling AdInjectionBrowserTest after Activity Log refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/dom_activity_logger.cc

Issue 384983003: Enabling AdInjectionBrowserTest after Activity Log refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/dom_activity_logger.cc

diff --git a/extensions/renderer/dom_activity_logger.cc b/extensions/renderer/dom_activity_logger.cc

index 14a82d30ba2c4b77c827ebff89b9ea376520f859..2d8ca4667a122350ec3a63af72506a33579edc16 100644

--- a/extensions/renderer/dom_activity_logger.cc

+++ b/extensions/renderer/dom_activity_logger.cc

@@ -6,7 +6,6 @@

#include "content/public/renderer/render_thread.h"

#include "content/public/renderer/v8_value_converter.h"

-#include "extensions/common/ad_injection_constants.h"

#include "extensions/common/dom_action_types.h"

#include "extensions/common/extension_messages.h"

#include "extensions/renderer/activity_log_converter_strategy.h"

@@ -29,8 +28,6 @@ void AppendV8Value(const std::string& api_name,

DCHECK(list);

scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());

ActivityLogConverterStrategy strategy;

- strategy.set_enable_detailed_parsing(

- ad_injection_constants::ApiCanInjectAds(api_name));

converter->SetFunctionAllowed(true);

converter->SetStrategy(&strategy);

scoped_ptr<base::Value> value(converter->FromV8Value(

« no previous file with comments | « extensions/renderer/activity_log_converter_strategy.cc ('k') | no next file » | no next file with comments »