chrome/browser/extensions/activity_log/ad_injection_browsertest.cc - Issue 384983003: Enabling AdInjectionBrowserTest after Activity Log refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/ad_injection_browsertest.cc

Issue 384983003: Enabling AdInjectionBrowserTest after Activity Log refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_actions.cc ('k') | chrome/browser/extensions/activity_log/ad_injection_unittest.cc » ('j') | chrome/test/data/extensions/activity_log/ad_injection/content_script.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/ad_injection_browsertest.cc

diff --git a/chrome/browser/extensions/activity_log/ad_injection_browsertest.cc b/chrome/browser/extensions/activity_log/ad_injection_browsertest.cc

index 333e4bca989a845ead62f666b1d68b7ed610ca1c..9aa01afb4190d6c88568efdbd7deb983b203ddca 100644

--- a/chrome/browser/extensions/activity_log/ad_injection_browsertest.cc

+++ b/chrome/browser/extensions/activity_log/ad_injection_browsertest.cc

@@ -352,9 +352,7 @@ testing::AssertionResult AdInjectionBrowserTest::HandleJSError(

// content script cleans up after itself. For significantly more detailed

// comments, see

// chrome/test/data/extensions/activity_log/ad_injection/content_script.js.

-// TODO(pmarch): Enable this test once modifications to Blink are done,

-// crbug.com/388287.

-IN_PROC_BROWSER_TEST_F(AdInjectionBrowserTest, DISABLED_DetectAdInjections) {

+IN_PROC_BROWSER_TEST_F(AdInjectionBrowserTest, DetectAdInjections) {

const Extension* extension = LoadExtension(test_data_dir_);

ASSERT_TRUE(extension);