Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.h

Issue 384983003: Enabling AdInjectionBrowserTest after Activity Log refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_actions.h
diff --git a/chrome/browser/extensions/activity_log/activity_actions.h b/chrome/browser/extensions/activity_log/activity_actions.h
index 211331285551ea177752b077c64acc0db1b1b71a..e90065418c9efce7b53e5f95ccb811e8bd175a5a 100644
--- a/chrome/browser/extensions/activity_log/activity_actions.h
+++ b/chrome/browser/extensions/activity_log/activity_actions.h
@@ -185,17 +185,11 @@ class Action : public base::RefCountedThreadSafe<Action> {
// ad injection.
void MaybeUploadUrl(rappor::RapporService* rappor_service) const;
- // Checks an action that modified the src of an element for ad injection.
- InjectionType CheckSrcModification() const;
- // Checks an action with the appendChild API for ad injection.
- // |ad_type_out| is populated with the type of ad which was injected, if there
- // was an injection.
- InjectionType CheckAppendChild(AdType* ad_type_out) const;
- // Checks a DOM object (e.g. an appended child) for ad injection.
- // |ad_type_out| is populated with the type of ad which was injected, if there
- // was an injection.
- InjectionType CheckDomObject(const base::DictionaryValue* object,
- AdType* ad_type_out) const;
+ // Checks an action that modified the src or href of an element for ad
+ // injection.
+ InjectionType CheckAttrModification() const;
+ // Checks an action that adds an element for ad injection.
+ InjectionType CheckElementAddition() const;
std::string extension_id_;
base::Time time_;

Powered by Google App Engine
This is Rietveld 408576698