Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: extensions/renderer/activity_log_converter_strategy.h

Issue 384983003: Enabling AdInjectionBrowserTest after Activity Log refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/extensions.gyp ('k') | extensions/renderer/activity_log_converter_strategy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_ 5 #ifndef EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_
6 #define EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_ 6 #define EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "content/public/renderer/v8_value_converter.h" 10 #include "content/public/renderer/v8_value_converter.h"
(...skipping 18 matching lines...) Expand all
29 // content::V8ValueConverter::Strategy implementation. 29 // content::V8ValueConverter::Strategy implementation.
30 virtual bool FromV8Object(v8::Handle<v8::Object> value, 30 virtual bool FromV8Object(v8::Handle<v8::Object> value,
31 base::Value** out, 31 base::Value** out,
32 v8::Isolate* isolate, 32 v8::Isolate* isolate,
33 const FromV8ValueCallback& callback) const OVERRIDE; 33 const FromV8ValueCallback& callback) const OVERRIDE;
34 virtual bool FromV8Array(v8::Handle<v8::Array> value, 34 virtual bool FromV8Array(v8::Handle<v8::Array> value,
35 base::Value** out, 35 base::Value** out,
36 v8::Isolate* isolate, 36 v8::Isolate* isolate,
37 const FromV8ValueCallback& callback) const OVERRIDE; 37 const FromV8ValueCallback& callback) const OVERRIDE;
38 38
39 void set_enable_detailed_parsing(bool enable_detailed_parsing) {
40 enable_detailed_parsing_ = enable_detailed_parsing;
41 }
42
43 private: 39 private:
44 bool FromV8Internal(v8::Handle<v8::Object> value, 40 bool FromV8Internal(v8::Handle<v8::Object> value,
45 base::Value** out, 41 base::Value** out,
46 v8::Isolate* isolate, 42 v8::Isolate* isolate,
47 const FromV8ValueCallback& callback) const; 43 const FromV8ValueCallback& callback) const;
48 44
49 // Whether or not to extract a detailed value from the passed in objects. We
50 // do this when we need more information about the arguments in order to
51 // determine, e.g., if an ad was injected.
52 bool enable_detailed_parsing_;
53
54 DISALLOW_COPY_AND_ASSIGN(ActivityLogConverterStrategy); 45 DISALLOW_COPY_AND_ASSIGN(ActivityLogConverterStrategy);
55 }; 46 };
56 47
57 } // namespace extensions 48 } // namespace extensions
58 49
59 #endif // EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_ 50 #endif // EXTENSIONS_RENDERER_ACTIVITY_LOG_CONVERTER_STRATEGY_H_
OLDNEW
« no previous file with comments | « extensions/extensions.gyp ('k') | extensions/renderer/activity_log_converter_strategy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698