Enabling AdInjectionBrowserTest after Activity Log refactoring.

chrome/test/data/extensions/activity_log/ad_injection/content_script.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains the tests for detecting extension's ad injection in
 // Chrome. This contains many different, independent tests, but it is all run
 // as a "single" browser test. The reason for this is that we want to do many
 // short tests for ad injection, and the set-up/tear-down time for a browsertest
 // implementation of each would be prohibitive.
 // See also chrome/browser/extensions/activity_log/ad_injection_browsertest.cc
@@ skipping 13 matching lines @@
 //        10       |    2   | 57.945s  | 26.580s  |  4.950s |
 //        100      |    2   |   N/A    |   N/A    |   N/A   |
 // ----------------------------------------------------------
 
 // This html block is just designed to be a massive playground for ad injectors,
 // where they can let loose and have fun.
 // We use this to populate our page at the start of every test.
 var kBodyHtml =
     '<iframe id="ad-iframe" src="http://www.known-ads.adnetwork"></iframe>' +
     '<iframe id="non-ad-iframe" src="http://www.not-ads.adnetwork"></iframe>' +
-    '<embed id="ad-embed" src="http://www.known-ads.adnetwork"><embed>' +
-    '<embed id="non-ad-embed" src="http://www.not-ads.adnetwork"><embed>' +
     '<a id="ad-anchor" href="http://www.known-ads.adnetwork"></a>' +
     '<a id="non-ad-anchor" href="http://www.not-ads.adnetwork"></a>' +
     '<div id="empty-div"></div>';
 
 /**
  * The AdInjectorTest infrastructure. Basically, this allows the test to follow
  * a simple iteration cycle:
  * - Signal the C++ test that we're going to do page setup, and we shouldn't
  *   record any ad-injector events (as some of the page setup could qualify).
  * - Do the page setup, which involves creating a 'playground' for ad injectors
- *   of iframes, embeds, etc. See also ad_injectors.html. We do this set up for
- *   each test, so that none of the tests conflicts with each other.
+ *   of iframes, etc. See also ad_injectors.html. We do this set up for each
+ *   test, so that none of the tests conflicts with each other.
  * - Signal that we are done with page setup, and should start recording events.
  * - Run the next test.
  * - Signal that the test is done, and we should check for the result.
  *
  * This cycle repeats, and should be done synchronously so that we don't end up
  * recording events which we shouldn't, and can attribute each event to its
  * cause.
  * @constructor
  */
 function AdInjectorTest(functions) {
@@ skipping 115 matching lines @@
 var kIframeAdTemplate = document.createElement('iframe');
 kIframeAdTemplate.src = kAdNetwork;
 
 /**
  * @return An iframe element which will count as ad injection in the tests.
  */
 var getIframeAd = function() {
   return kIframeAdTemplate.cloneNode(true);
 };
 
-// Creates an embed ad, like so:
-// <embed src="http://www.known-ads.adnetwork"></embed>
-var kEmbedAdTemplate = document.createElement('embed');
-kEmbedAdTemplate.src = kAdNetwork;
-
-/**
- * @return An embed element which will count as ad injection in the tests.
- */
-var getEmbedAd = function() {
-  return kEmbedAdTemplate.cloneNode(true);
-};
-
 // Creates an anchor ad, like so:
 // <a href="http://www.known-ads.adnetwork"></a>
 var kAnchorAdTemplate = document.createElement('a');
 kAnchorAdTemplate.href = kAdNetwork;
 
 /**
  * @return An anchor ('a') element which will count as ad injection in the
  *     tests.
  */
 var getAnchorAd = function() {
@@ skipping 29 matching lines @@
  * All test functions must be synchronous.
  * @type {Array.<Function>}
  */
 var functions = [];
 
 // Add a bunch of elements, but nothing that looks like ad injection (no
 // elements with an external source, no modifying existing sources).
 functions.push(function NoAdInjection() {
   var div = document.createElement('div');
   var iframe = document.createElement('iframe');
-  var embed = document.createElement('embed');
   var anchor = document.createElement('anchor');
   var span = document.createElement('span');
   span.textContent = 'Hello, world';
   div.appendChild(iframe);
-  div.appendChild(embed);
   div.appendChild(anchor);
   div.appendChild(span);
   document.body.appendChild(div);
   return NO_AD_INJECTION;
 });
 
 // Add a new iframe with an AdNetwork source by creating the element and
 // appending it.
 functions.push(function NewIframeAdNetwork() {
   document.body.appendChild(getIframeAd());
   return INJECTION_NEW_AD;
 });
 
 // Add a new iframe which does not serve ads. We should not record anything.
 functions.push(function NewIframeLikelyAdNetwork() {
   var frame = document.createElement('iframe');
   document.body.appendChild(frame).src = kMaybeAdNetwork;
   return INJECTION_LIKELY_NEW_AD;
 });
 
 // Modify an iframe which is currently in the DOM, switching the src to an
 // ad network.
 functions.push(function ModifyExistingIframeToAdNetwork() {
   var frame = $('non-ad-iframe');
   frame.src = kAdNetwork;

[Devlin, 2014/07/15 17:21:52]

Since we have a lower-level api now, can we check things like
frame.setAttribute('src', kAdNetwork) as well?

[pmarch, 2014/07/16 10:34:17]

Done.

   return INJECTION_NEW_AD;
 });
 
-// Add a new embed element which serves ads.
-functions.push(function NewEmbedAdNetwork() {
-  document.body.appendChild(getEmbedAd());
-  return INJECTION_NEW_AD;
-});
-
-// Add a new embed element which does not serve ads. We should not record
-// anything.
-functions.push(function NewEmbedLikelyAdNetwork() {
-  var embed = document.createElement('embed');
-  document.body.appendChild(embed).src = kMaybeAdNetwork;
-  return INJECTION_LIKELY_NEW_AD;
-});
-
-// Modify an embed which is currently in the DOM, switching the src to an
-// ad network.
-functions.push(function ModifyExistingEmbedToAdNetwork() {
-  var embed = $('non-ad-embed');
-  embed.src = kAdNetwork;
-  return INJECTION_NEW_AD;
-});
-
 // Add a new anchor element which serves ads.
 functions.push(function NewAnchorAd() {
   document.body.appendChild(getAnchorAd());
   return INJECTION_NEW_AD;
 });
 
 functions.push(function NewAnchorLikelyAd() {
   var anchor = document.createElement('a');
   document.body.appendChild(anchor).href = kMaybeAdNetwork;
   return INJECTION_LIKELY_NEW_AD;
@@ skipping 23 matching lines @@
   return INJECTION_NEW_AD;
 });
 
 // Add a new element which has a nested ad, to ensure we do a deep check of
 // elements appended to the dom.
 functions.push(function NewNestedAd() {
   document.body.appendChild(getNestedAd());
   return INJECTION_NEW_AD;
 });
 
-// Switch an existing embed ad to a new ad network.
-functions.push(function ReplaceEmbedAd() {
-  $('ad-embed').src = kAdNetwork2;
-  return INJECTION_REPLACED_AD;
-});
-
 // Switch an existing iframe ad to a new ad network.
 functions.push(function ReplaceIframeAd() {
   $('ad-iframe').src = kAdNetwork2;
   return INJECTION_REPLACED_AD;
 });
 
 // Switch an existing anchor ad to a new ad network.
 functions.push(function ReplaceAnchorAd() {
   $('ad-anchor').href = kAdNetwork2;
   return INJECTION_REPLACED_AD;
 });
 
-// Remove an existing embed ad by setting it's src to a non-ad network.
-functions.push(function RemoveAdBySettingSrc() {

[Devlin, 2014/07/15 17:21:52]

These don't work anymore?

[pmarch, 2014/07/16 10:34:17]

Yes, there is no tracking for embed elements by Activity Logger.

-  $('ad-embed').src = kMaybeAdNetwork;
-  return INJECTION_REMOVED_AD;
-});
-
-// Ensure that we flag actions that look a lot like ad injection, even if we're
-// not sure.
-functions.push(function LikelyReplacedAd() {
-  // Switching from one valid url src to another valid url src is very
-  // suspicious behavior, and should be relatively rare. This helps us determine
-  // the effectiveness of our ad network recognition.
-  $('non-ad-embed').src = 'http://www.thismightbeanadnetwork.ads';
-  return INJECTION_LIKELY_REPLACED_AD;
-});
-
 // Verify that we do not enter the javascript world when we check for ad
 // injection.
 functions.push(function VerifyNoAccess() {
   var frame = document.createElement('iframe');
   frame.__defineGetter__('src', function() {
     throw new Error('Forbidden access into javascript execution!');
     return kAdNetwork;
   });
   return NO_AD_INJECTION;
 });
 
 // TODO(rdevlin.cronin): We are not covering every case yet. Fix this.
 // See crbug.com/357204.
 
 // Kick off the tests.
 var test = new AdInjectorTest(functions);
 test.runNextFunction();