Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2902)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 384983002: Count external PDF viewer usage in print preview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Thu 07/10/2014 16:03:32.64 Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
index ffc06bd089d6371bb2aa9bbbeff82f68363a3aa5..27ab250de074ecbe1b6280cc66eac14b10c78c11 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
@@ -118,6 +118,7 @@ enum PrintSettingsBuckets {
HEADERS_AND_FOOTERS,
CSS_BACKGROUND,
SELECTION_ONLY,
+ EXTERNAL_PDF_PREVIEW,
PRINT_SETTINGS_BUCKET_BOUNDARY
};
@@ -261,6 +262,12 @@ void ReportPrintSettingsStats(const base::DictionaryValue& settings) {
&selection_only) && selection_only) {
ReportPrintSettingHistogram(SELECTION_ONLY);
}
+
+ bool external_preview = false;
+ if (settings.GetBoolean(printing::kSettingOpenPDFInPreview,
+ &external_preview) && external_preview) {
+ ReportPrintSettingHistogram(EXTERNAL_PDF_PREVIEW);
+ }
}
// Callback that stores a PDF file on disk.
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698